Bug 275866 - net/librdkafka: Build fails, link error 'rd_ut_coverage_check' failed: symbol not defined
Summary: net/librdkafka: Build fails, link error 'rd_ut_coverage_check' failed: symbol...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Luca Pizzamiglio
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-21 05:42 UTC by robbak
Modified: 2024-01-18 10:25 UTC (History)
1 user (show)

See Also:
pizzamig: maintainer-feedback+


Attachments
Patch to remove errant symbol (367 bytes, text/plain)
2023-12-21 05:42 UTC, robbak
no flags Details
Build Script (70.37 KB, text/plain)
2023-12-21 05:43 UTC, robbak
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description robbak 2023-12-21 05:42:13 UTC
Created attachment 247181 [details]
Patch to remove errant symbol

Build fails on my system. To me, it looks like the system has accidentally included something from the unit test system.

The build worked for me after removing the reference to this symbol in the lds-gen.py script. Dependent ports built too, but I don't know enough about the services this port provides to test functionality.

Build script and patch attached.
Comment 1 robbak 2023-12-21 05:43:25 UTC
Created attachment 247182 [details]
Build Script
Comment 2 Luca Pizzamiglio freebsd_committer freebsd_triage 2023-12-27 15:22:02 UTC
Hi! Thanks for reporting.

In poudriere, the build succeed as there is no python3, and the python script is not used.
Locally, I've built the librdkafka with python3 to replicate your error, but error message is only a warning, so I can successfully build it.

Are you enabling -Werror maybe?

The offending symbol doesn't seem accidentally but explicitly included by the python script, so I'm not inclined in removing it.

What do yo think?
Comment 3 robbak 2023-12-28 04:34:53 UTC
Thanks. No, I'm not (knowingly) using -Werror. Nothing in my make.conf that could conceivably cause that. And it clearly states it as an error, not a warning.

Based on the info you gave me, I got it to build by defining "WITH_LDS=n" in the make args. Interesting to know how the build changes when it uses, or doesn't use, this script.

--- a/net/librdkafka/Makefile
+++ b/net/librdkafka/Makefile
@@ -25,7 +25,7 @@ USE_GITHUB=   yes
 GH_ACCOUNT=    edenhill
 
 GNU_CONFIGURE= yes
-MAKE_ARGS=     pkgconfigdir=${PREFIX}/libdata/pkgconfig
+MAKE_ARGS=     pkgconfigdir=${PREFIX}/libdata/pkgconfig WITH_LDS=n
 CONFIGURE_ARGS+=       --disable-sasl \
                                        --enable-ssl \
                                        --enable-strip