Bug 275933 - x11-wm/xfce4 depends on deprecated samba413 due to it being set as default version for samba port
Summary: x11-wm/xfce4 depends on deprecated samba413 due to it being set as default ve...
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Timur I. Bakeyev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-12-25 18:47 UTC by Jürgen Weber
Modified: 2024-04-01 13:23 UTC (History)
2 users (show)

See Also:
madpilot: maintainer-feedback+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jürgen Weber 2023-12-25 18:47:31 UTC
I tried to replace samba413 with samba416 and was surprised that removing samba413  removed xfce, too.
Couldn't the samba dependency be updated or even removed?

see 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=267142
Bug 267142 - net/samba413: Mark DEPRECATED and set EXPIRATION_DATE 

pkg remove samba413
Checking integrity... done (0 conflicting)
Deinstallation has been requested for the following 6 packages (of 0 packages in the universe):

Installed packages to be REMOVED:
        gvfs: 1.50.2_1
        samba413: 4.13.17_8
        thunar: 4.18.8
        thunar-archive-plugin: 0.5.2
        xfce: 4.18_1
        xfce4-desktop: 4.18.1_2
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2023-12-25 21:17:08 UTC
XFCE ports have no control on this.

XFE includes thunar that depends on gvfs, and gvfs depends on samba through USES=samba:lib.


ports/Mk/Uses/samba.mk contorls dependencies on samba and respect default versions.

ports/Mk/bsd.default-versions.mk controls default versions of a bunch of ports. It contains:

# Possible values: 4.13, 4.16
SAMBA_DEFAULT?=         4.13


So the official ports tree at present defaults to depending on 4.13.

You can build your own ports and define:

DEFAULT_VERSIONS= samba=4.16

in /etc/make.conf (or the relevant configuration if using poudriere) and change the dependency.

At present the official binary packages are hardcoded to depend on samba 4.13. Only way to depend on 4.16 is to build your own ports configuring the system as described above.

I suspect there is a plan to switch the official default version at some point.

Hope this explains the situation.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2023-12-25 21:43:42 UTC
You should take a look at bug #267142 and the maliing list thread at [1]

The expiration date was recently extended BTW (see [2]). I guess the extension was done to allow some kind of transition.


[1] https://lists.freebsd.org/archives/dev-commits-ports-all/2023-November/088169.html

[2] https://lists.freebsd.org/archives/dev-commits-ports-all/2023-December/091155.html
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2023-12-28 08:10:05 UTC
@Jürgen Weber

Can this be closed? (as works as intended I think)

The issue is that the ports tree as a while needs to change the samba default version, nothing specific to xfce.

You should discuss this in the ports@mailing list or file a bug report against the ports infrastructure about this.
Comment 4 Jürgen Weber 2023-12-28 08:54:39 UTC
Well, for me as end user the issue is not solved, my XFCE package is chained to a deprecated Samba version. The problem goes not away by discussing it away.

But feel free to move the bug to a proper location.
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2023-12-28 13:09:55 UTC
(In reply to Jürgen Weber from comment #4)

I must agree your reasoning makes sense, but unluckily there isn't much that can be done from the XFCE side of things.

I'm redirecting this to the samba ports maintainer.


@timur

As reported by the user the default binary packages depend on a deprecated samba version. I cannot do much about this from the XFCE side, and am not informed about the details of the samba port/project.

Could you share with the user some insight about the situation and if there is a plan to change the default version?

Thanks in advance!
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2024-02-09 16:27:13 UTC
(In reply to Jürgen Weber from comment #4)

I noticed that the default version of samba has been changed to 4.16 just before the latest ports quarterly was branched. [1]

This means now xfce ports should depend on that version, which is not marked as deprecated in the ports tree.

Also, today [2] a newer version of samba was committed to the ports tree. At some point that will be switched as the default one.


I guess now this issue can be marked as solved.



[1] https://cgit.freebsd.org/ports/commit/?id=fabf8b5d116512e2c0339c1a17340370d753e271

[2] https://cgit.freebsd.org/ports/commit/?id=b0a4fa4a12b096897f347755106940220e94c114
Comment 7 Rene Ladan freebsd_committer freebsd_triage 2024-04-01 13:23:26 UTC
The default is Samba 4.16 since 2024Q1 (see https://cgit.freebsd.org/ports/commit/?id=fabf8b5d116512e2c0339c1a17340370d753e271) and Samba 4.13 expired today, closing this as OBE.