Created attachment 247426 [details] git-format-patch The currently in git is from 2006. This updates the port to the latest version, from 2018. I tried to deal with a problem the best way I could: the tar file is named z80-asm-current.tar.gz, but it untars into z80-asm-2.4.1. So I have a less than ideal `DISTNAME=${PORTNAME}-current` in the Makefile, but the danger of having a version named `current` is mitigated by explicitely setting `WRKSRC=${PWD}/work/${PORTNAME}-${PORTVERSION}`, PORTVERSION being 2.4.1. It's the best way that I found to deal with the discrepency. If there is a better way to do it, let me know! I have contacted the maintainer upstream to see if he would take some patches, and if the tar file could be renamed to include a version number, but so far no answer. In a future update I might fork the source to my own github repo for this type of maintenance.
Created attachment 247434 [details] Patch 2: fix poudriere build
Also removed LICENSE_FILE because the one bundled with the source is a template that's not been filled.
^Triage: [tags] in issue Titles are deprecated. ^Triage: Simplifying title ^Triage: If there is a changelog or release notes URL available for this version, please add it to the URL field. Thanks!
Hi Laurent, The patch does not apply. Would you mind having a look at it?
Yes there was a commit made after I created the patch. I'll fix it.
Created attachment 250220 [details] Update to 2.4.1 Updated the patch to take into account a commit that was made recently and broke the previous patch.
Ready for commit devel/z80-asm: Update to 2.4.1 Changes: - Update 2.4.p3 to 2.4.1 - Fix various (but not all) compilation warnings QA: - portlint: no new warnings - poudriere: OK
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=88505e8a3f59e6dd0a71984f65d6bbefc2b9add2 commit 88505e8a3f59e6dd0a71984f65d6bbefc2b9add2 Author: Laurent <laurent.chardon@gmail.com> AuthorDate: 2024-04-25 16:28:36 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-04-26 10:28:09 +0000 devel/z80-asm: update to 2.4.1 ChangeLog: http://wwwhomes.uni-bielefeld.de/achim/z80-asm/CHANGELOG-2.4.1 Submitter becomes maintainer. Already maintaining several ports. PR: 276089 Reported by: laurent.chardon@gmail.com devel/z80-asm/Makefile | 35 ++++-------------- devel/z80-asm/distinfo | 7 ++-- devel/z80-asm/files/patch-Makefile (new) | 43 +++++++++++++++++++++++ devel/z80-asm/files/patch-hardware_Makefile (new) | 29 +++++++++++++++ devel/z80-asm/files/patch-memory.c (new) | 38 ++++++++++++++++++++ devel/z80-asm/files/patch-z80-asm.c (new) | 11 ++++++ devel/z80-asm/files/patch-z80-mon.c (new) | 11 ++++++ 7 files changed, 141 insertions(+), 33 deletions(-)