Bug 276127 - math/py-triangle: update to 20230923
Summary: math/py-triangle: update to 20230923
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Diane Bruce
URL:
Keywords:
Depends on:
Blocks: 275494
  Show dependency tree / graph
 
Reported: 2024-01-05 15:24 UTC by Ruslan Makhmatkhanov
Modified: 2024-01-08 20:39 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (db)

Attachments
fix build with python>3.9 (686.86 KB, patch)
2024-01-05 15:24 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
update to 20230923 (1.38 KB, patch)
2024-01-05 16:14 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-05 15:24:03 UTC 
Created attachment 247462 [details]
fix build with python>3.9

math/py-triangle fails to build with python3.10 and 3.11 and blocks this PR: 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=275494

Regenerating core.pyx file with newer cython version fix the build. So here is the patch. Here is how to reproduce those steps manually:

math/py-triangle% sudo make install py39-cython
math/py-triangle% make extract
math/py-triangle% cd work-py39/triangle-20200424/triangle/
math/py-triangle/work-py39/triangle-20200424/triangle% mv core.c core.c.orig
math/py-triangle/work-py39/triangle-20200424/triangle% cython3.9 core.pyx
math/py-triangle/work-py39/triangle-20200424/triangle% cd ../../../
math/py-triangle% make makepatch
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-01-05 16:14:11 UTC 
Created attachment 247463 [details]
update to 20230923

here is a better option. this patch updates port to latest version, so bundled core.c file already generated with new cython.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-01-08 20:38:43 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1901b8ce71d6122652c34ca0b9d04df1933e73bf

commit 1901b8ce71d6122652c34ca0b9d04df1933e73bf
Author:     Diane Bruce <db@FreeBSD.org>
AuthorDate: 2024-01-08 20:30:44 +0000
Commit:     Diane Bruce <db@FreeBSD.org>
CommitDate: 2024-01-08 20:30:44 +0000

    math/py-triangle: update to 20230923

    - updated to 20230923
    - K&R support removed

    PR:             276127
    Reported by:    Ruslan Makhmatkhanov <rm@FreeBSD.org>

 math/py-triangle/Makefile | 8 ++++++--
 math/py-triangle/distinfo | 8 +++++---
 2 files changed, 11 insertions(+), 5 deletions(-)