Bug 276210 - textproc/py-sphinxcontrib-svg2pdfconverter: update to 1.2.3 & OPTION'ify rendering engines
Summary: textproc/py-sphinxcontrib-svg2pdfconverter: update to 1.2.3 & OPTION'ify rend...
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL: https://pypi.org/project/sphinxcontri...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-09 01:50 UTC by Alastair Hogge
Modified: 2024-10-31 06:14 UTC (History)
3 users (show)

See Also:


Attachments
OPTION'ify rendering engines (1.88 KB, patch)
2024-01-09 01:50 UTC, Alastair Hogge
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alastair Hogge 2024-01-09 01:50:46 UTC
Created attachment 247537 [details]
OPTION'ify rendering engines

textproc/py-sphinxcontrib-svg2pdfconverter: OPTION'ify runtime renderers

Some Port housekeeping, move the three different runtime renderers to OPTIONs: a lighter weight Cairo based renderer, the default Inkscape (was not originally listed as a dependency) renderer, and the current Rust implementation of libsvg2.
Comment 1 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-20 06:09:06 UTC
I tried install inkscape, will require 512 Mib more space. If a user (without inkscape) use py-sphinxcontrib-svg2pdfconverter and upgrade the packages should install hundreds of megabytes.
I suggest remove the inkscape option from default options.
Comment 2 Alastair Hogge 2024-06-20 12:54:55 UTC
(In reply to Zsolt Udvari from comment #1)

Good idea. What are your thoughts on removing the Rust SVG renderer from the default too? I only use the Python Cairo renderer on my workstation.
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-06-21 18:40:01 UTC
(In reply to Alastair Hogge from comment #2)
I don't use this software but checking the dependencies: the librsvg port is dependency of gtk30 which is a widely used port so I think the librsvg port is probably installed already (check pkg info --required-by librsvg2\*) and maybe can a simple dependency (without option).

Python-cairo-svg: on my desktop doesn't require many plus space, can be default.

Another idea: forget the options, only the librsvg will be dependency. And create a pkg-message which informs user about liferea and py-cairosvg: can install and use them as renderer.
Comment 4 Alastair Hogge 2024-07-02 09:40:51 UTC
I am not a position at the moment to investigate this. From memory, I was favouring the Cairo renderer because of the reduced amount of dependencies, and space as you mention. I agree with making that the default, as I prefer not to assume on GTK be common, or anything else in general really, it is a terrible habit.

My reason for the adding all the options was because it enables an automatic concrete dependency, which alleviates the user from managing the dependencies, thus it keeps package and dependency management as a task for pkg, not the user.

If you are OK with that, I will upload a new patch when I am able.

Thanks for your interest in the problem report.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-02 09:59:02 UTC
I think should drop inkscape from options and dependencies and inform user in pkg-message: if he/she wants use inkscape as renderer should install it manually.
Comment 6 Alastair Hogge 2024-07-02 10:16:13 UTC
(In reply to Zsolt Udvari from comment #5)

I still do not understand your reasoning for this. Surely inkscape could be left as an option, defaulted to off, than the mechanisms of the Ports Framework are still there, enabling the user to make the choice, not you or I.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-02 11:01:43 UTC
(In reply to Alastair Hogge from comment #6)
"defaulted to off"
Okay, I think it's good. I forgot it :)
Comment 8 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-21 17:29:25 UTC
Could you please provide an updated patch?
Comment 9 Zsolt Udvari freebsd_committer freebsd_triage 2024-09-21 17:30:01 UTC
And the 1.2.3 is out :)
Comment 10 Alastair Hogge 2024-09-22 00:10:11 UTC
(In reply to Zsolt Udvari from comment #8)

Will do when replacement HBA, SFF cables, and some disks arrive from overseas.
Comment 11 Alastair Hogge 2024-09-22 00:10:34 UTC
Comment on attachment 247537 [details]
OPTION'ify rendering engines

Patch is outdated, and requires more work.
Comment 12 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-28 06:44:14 UTC
Friendly ping.
Comment 13 Alastair Hogge 2024-10-31 06:14:45 UTC
(In reply to Zsolt Udvari from comment #12)

Hello,

I think I have all my hardware now to rebuild the NAS. I hope to get started on the weekend.