Bug 276313 - multimedia/ffmpeg Organise port options into groups
Summary: multimedia/ffmpeg Organise port options into groups
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-multimedia (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-14 09:33 UTC by mhambley
Modified: 2024-01-27 14:20 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (multimedia)


Attachments
Patch to make greater use of option grouping (4.02 KB, patch)
2024-01-14 09:33 UTC, mhambley
no flags Details | Diff
More complete version of the previous patch (12.32 KB, patch)
2024-01-22 12:01 UTC, mhambley
no flags Details | Diff
Further improved patch (5.39 KB, patch)
2024-01-27 14:20 UTC, mhambley
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mhambley 2024-01-14 09:33:43 UTC
Created attachment 247637 [details]
Patch to make greater use of option grouping

This isn't a bug as such but I couldn't see a way to contribute - the port maintainers e-mail address being a private mailing list.

The option list is fairly mighty and I find it hard to navigate, particularly where there are several options which cover the same thing. Attached is a patch which makes a first stab at grouping many of the options to make them easier to understand.

It is incomplete and there are still discussions to be had about categories and ordering but it should serve as a proof of concept.
Comment 1 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-14 19:03:22 UTC
NETWORK or IO:
OPTIONS_GROUP=		NETWORK
OPTIONS_GROUP_IO=	CDIO DC1394 LIBBLURAY NETWORK SMB SSH

Order:
OPTIONS_GROUP_VIDEO= xxx
OPTIONS_GROUP_SOUND= xxx

Order:
OPENVINO_DESC=	OpenVINO as a DNN module backend for DNN based filters like dnn_processing
COMPILE_DESC=	Compile options
POCKETSPHINX_DESC=	Automatic Speech Recognition via PocketSphinx
Comment 2 mhambley 2024-01-22 12:01:43 UTC
Created attachment 247843 [details]
More complete version of the previous patch

The change is more complete now and i think I've tackled the suggestions made above.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-22 14:24:51 UTC
(In reply to mhambley from comment #2)
Why option NETWORK is in GROUPs list?
Comment 4 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-22 14:27:40 UTC
"OPTIONS_GROUP=" must be after "OPTIONS_DEFINE=" and before "OPTIONS_DEFAULT=".

Example:
OPTIONS_DEFINE= A B
OPTIONS_GROUP= X Y
OPTIONS_GROUP_X= C D
OPTIONS_GROUP_Y= E F
OPTIONS_DEFAULT= A C F
Comment 5 mhambley 2024-01-27 14:20:34 UTC
Created attachment 248004 [details]
Further improved patch

The presence of "NETWORK" in the group list was a mistake on my part.

Thanks for explaining the required ordering.