Bug 276388 - net/openldap ports don't need OpenSSL-1.1.1
Summary: net/openldap ports don't need OpenSSL-1.1.1
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Xin LI
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-16 20:34 UTC by Mikhail Teterin
Modified: 2024-01-23 08:09 UTC (History)
2 users (show)

See Also:


Attachments
Relax requirements for OpenSSL (594 bytes, patch)
2024-01-16 20:34 UTC, Mikhail Teterin
delphij: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Teterin freebsd_committer freebsd_triage 2024-01-16 20:34:53 UTC
Created attachment 247714 [details]
Relax requirements for OpenSSL

Although upstream's configure insists on OpenSSL-1.1.1, the software compiles find against 1.0.2u (and, possibly, even earlier versions).

The proposed patch relaxes the requirements allowing both the server and client ports to build on the earlier FreeBSD-releases.

By the way, the files/patch-configure should be removed altogether -- because the port uses autoconf to produce a whole new configure-script from configure.ac anyway.

I tested this with openldap26-server and -client, but, in all likelihood, the same is true about the openldap25 ports.make
Comment 1 Xin LI freebsd_committer freebsd_triage 2024-01-16 20:47:00 UTC
Patch looks fine to me, could you please push it?
Comment 2 Michael Osipov freebsd_committer freebsd_triage 2024-01-17 12:13:20 UTC
Stupid question: Why does this makes sense although 1.0.2 is dead?
Comment 3 Xin LI freebsd_committer freebsd_triage 2024-01-18 05:46:18 UTC
(In reply to Michael Osipov from comment #2)
I think it's probably to make it work with an EoL'ed FreeBSD release; we don't generally support doing it but the change is against configure.ac and does not affect runtime behavior.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-01-18 22:58:37 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=6120c446784035dbbf34051ed87c8269c1abd434

commit 6120c446784035dbbf34051ed87c8269c1abd434
Author:     Mikhail Teterin <mi@FreeBSD.org>
AuthorDate: 2024-01-18 22:54:21 +0000
Commit:     Mikhail Teterin <mi@FreeBSD.org>
CommitDate: 2024-01-18 22:54:21 +0000

    net/openldap26-server: relax OpenSSL version requirement

    The authors' configure insists on OpenSSL-1.1.1, but the software
    makes no use of the new features -- and can compile just as well
    against the older OpenSSL.

    Also remove patch-configure -- the freshly patch configure script
    was being overwritten anyway by the autoconf.

    PR:     276388

 net/openldap26-server/files/patch-configure (gone) | 32 ----------------------
 .../files/patch-configure.ac (new)                 | 16 +++++++++++
 2 files changed, 16 insertions(+), 32 deletions(-)
Comment 5 Mikhail T. 2024-01-22 19:37:45 UTC
(In reply to Xin LI from comment #1)
> Patch looks fine to me, could you please push it?

The openldap26 was easy, but openldap25 only invokes autoconf (thus recreating configure from configure.ac) if FETCH-option is enabled.

Thus, I'd either need to make autoconf unconditional in openldap25 too, or patch configure in addition to configure.ac... I, of course, prefer the former option -- which would keep the two ports closer with each other and reduce duplication.

But that's a more complex change, than you consented to, so here I am asking permission again :)

Would you:
 1. Do it yourself.
 2. Allow me to do it.
 3. Leave 25 alone -- whoever wants to install OpenLDAP on the older FreeBSD, can go with the 26?

Thank you!
Comment 6 Xin LI freebsd_committer freebsd_triage 2024-01-23 08:09:43 UTC
(In reply to Mikhail T. from comment #5)
Please feel free to do it (right now I don't really have the time to work on it) for the openldap25 ports.  Otherwise just leave this bug open and I'll take a look once I have some time.