Bug 276391 - [exp-run] move system calls to libsys
Summary: [exp-run] move system calls to libsys
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Only Me
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-17 00:42 UTC by Brooks Davis
Modified: 2024-02-09 00:37 UTC (History)
1 user (show)

See Also:
brooks: exp-run?


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2024-01-17 00:42:55 UTC
https://github.com/freebsd/freebsd-src/pull/908 contains a patch to move system calls out of libc and into libsys when libc is a dynamic library.  In theory, the visible impact of this change is that libc now exports a bunch more public symbols for _ and __sys_ prefixed versions of symbols old under the FBSDprivate_1.0 version so hopefully this shows up as a no-op.

I've not attempted to produce a diff as the diff summary is:
 382 files changed, 1635 insertions(+), 1234 deletions(-)

and most of that is files that are moved unchanged or with trivial modifications.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2024-01-19 20:09:02 UTC
installworld fails:


rm -f /poudriere/jails/mainamd64PR276391/usr/share/man/man2/recvmmsg.2 /poudriere/jails/mainamd64PR276391/usr/share/man/man2/recvmmsg.2.gz;  install -N /poudriere/jails/mainamd64PR276391/usr/src/etc -l h -o root -g wheel -m 444  /poudrie
re/jails/mainamd64PR276391/usr/share/man/man2/recv.2.gz /poudriere/jails/mainamd64PR276391/usr/share/man/man2/recvmmsg.2.gz
install: link /poudriere/jails/mainamd64PR276391/usr/share/man/man2/recv.2.gz -> /poudriere/jails/mainamd64PR276391/usr/share/man/man2/recvmmsg.2.gz: No such file or directory
--- realinstall_subdir_libexec ---
--- _proginstall ---
--- maninstall ---
--- realinstall_subdir_lib ---
*** [maninstall] Error code 71

make[5]: stopped in /poudriere/jails/mainamd64PR276391/usr/src/lib/libc
1 error
Comment 2 Brooks Davis freebsd_committer freebsd_triage 2024-01-22 22:28:10 UTC
(In reply to Antoine Brodin from comment #1)

Apologies, my usual test path doesn't test manpages and I missed this. Should be fixed now.
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2024-01-23 12:30:54 UTC
cmake-core fails to link which blocks a lot of stuff in the ports tree:

https://pkg-status.freebsd.org/gohan04/data/mainamd64PR276391-default-foo/2024-01-23_10h17m45s/logs/errors/cmake-core-3.28.1.log
Comment 4 Brooks Davis freebsd_committer freebsd_triage 2024-01-24 00:01:00 UTC
(In reply to Antoine Brodin from comment #3)
I believe I've fixed this. Thanks
Comment 6 Brooks Davis freebsd_committer freebsd_triage 2024-02-02 17:04:17 UTC
(In reply to Antoine Brodin from comment #5)
The patch turned out to trigger a couple bugs in rtld. Those are now fixed and these two ports build locally.
Comment 7 Brooks Davis freebsd_committer freebsd_triage 2024-02-09 00:37:10 UTC
Thank you for the various runs!

Apparently I should have waited for one more run due to the lang/gcc* breakage, but that's now fixed and hopefully that's it.