Bug 276558 - security/cargo-audit: no longer needs libgit2
Summary: security/cargo-audit: no longer needs libgit2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-23 15:39 UTC by Alan Somers
Modified: 2024-03-23 19:32 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
Remove the dependency on libgit2 (640 bytes, patch)
2024-01-23 15:39 UTC, Alan Somers 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2024-01-23 15:39:26 UTC 
Created attachment 247892 [details]
Remove the dependency on libgit2

Though it isn't mentioned in the changelog, cargo-audit no longer uses libgit2 as of 0.18.0.  The port builds successfully without it.

https://github.com/rustsec/rustsec/issues/1058#issuecomment-1806295368
Comment 1 commit-hook freebsd_committer freebsd_triage 2024-01-25 15:32:08 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ebede82362daa8997b260cb789b9113630190294

commit ebede82362daa8997b260cb789b9113630190294
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2024-01-25 15:01:34 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-01-25 15:31:26 +0000

    security/cargo-audit: no longer needs libgit2

    cargo-audit no longer uses libgit2 as of 0.18.0.
    The port builds successfully without it.

    PR:             276558

 security/cargo-audit/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2024-01-25 15:48:59 UTC 
Thanks!
Comment 3 Alan Somers freebsd_committer freebsd_triage 2024-03-08 18:25:24 UTC 
It looks like this inadvertently regressed when the port was upgraded to 0.19.0.  In addition, the dependency on libssh2 can be removed.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-03-23 19:20:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=af98160dc2ec2915d49b8ea9b3d9490840f2d19d

commit af98160dc2ec2915d49b8ea9b3d9490840f2d19d
Author:     Alan Somers <asomers@FreeBSD.org>
AuthorDate: 2024-03-23 19:18:56 +0000
Commit:     Mikael Urankar <mikael@FreeBSD.org>
CommitDate: 2024-03-23 19:19:38 +0000

    security/cargo-audit: no longer needs libgit2

    security/cargo-audit: no longer needs libgit2

    cargo-audit no longer uses libgit2 as of 0.18.0.
    The port builds successfully without it.

    PR:             276558

 security/cargo-audit/Makefile | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)