Bug 276649 - graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29
Summary: graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks: 276656
  Show dependency tree / graph
 
Reported: 2024-01-26 21:46 UTC by Daniel Engberg
Modified: 2024-03-17 13:04 UTC (History)
2 users (show)

See Also:
vsasjason: maintainer-feedback+

Attachments
Patch for pngcrush (534 bytes, patch)
2024-01-26 21:46 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-26 21:46:42 UTC 
Created attachment 247992 [details]
Patch for pngcrush

Fails to build with libpng 1.6.41 due to usage of undocumented feature to disable
Adler32 checksums.
Last release in 2017 and dead upstream, redirect users to graphics/oxipng or graphics/pngquant

Reference:
https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5
Comment 1 Anton Saietskii 2024-01-26 22:03:27 UTC 
Unless desktop@ willing to enable PNG_DISABLE_ADLER32_CHECK_SUPPORTED in libpng 1.6.41, I'm fine with deprecation. I, personally, haven't even used pngcrush for a long time.
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-01-27 10:11:20 UTC 
I'm using graphics/optipng for decades - very lightweight and lossless.
graphics/pngquant - isn't lossless.
graphics/oxipng - require rust.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-02-08 22:12:01 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=e2b4eb57621f1c96f678c210fe7d2474c904e295

commit e2b4eb57621f1c96f678c210fe7d2474c904e295
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-02-08 22:08:52 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-02-08 22:09:19 +0000

    graphics/pngcrush: Mark BROKEN and set expiration date to 2024-02-29

    Fails to build with libpng 1.6.41 due to usage of undocumented feature to
    disable Adler32 checksums.
    Last release in 2017 and dead upstream, redirect users to graphics/oxipng
    or graphics/pngquant

    Reference:
    https://github.com/pnggroup/libpng/commit/269b753496180cdb3082d87b0cd907905593dee5

    PR:             276649
    Reviewed by:    Anton Saietskii <vsasjason@gmail.com> (maintainer)

 graphics/pngcrush/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-02-08 22:20:46 UTC 
Committed, thanks
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-02-08 23:01:39 UTC 
graphics/optipng isn't in list of alternatives… :-(
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-03-17 13:04:00 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=28cee973cc5c64c14c17bd0f66e4227934f7ec55

commit 28cee973cc5c64c14c17bd0f66e4227934f7ec55
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-03-17 12:59:10 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-03-17 13:02:57 +0000

    www/fgallery: Remove PNGCRUSH option

    graphics/pngcrush no longer builds with libpng 1.6.41 or newer versions

    PR:             276649
    Approved by:    portmgr (blanket)

 www/fgallery/Makefile | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)