Bug 276670 - devel/utf8cpp: Update to 4.0.5
Summary: devel/utf8cpp: Update to 4.0.5
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Po-Chuan Hsieh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-27 20:22 UTC by Daniel Engberg
Modified: 2024-03-09 17:23 UTC (History)
1 user (show)

See Also:

Attachments
Patch for utf8cpp (3.00 KB, patch)
2024-01-27 20:55 UTC, Daniel Engberg 		no flags Details | Diff
Patch for utf8cpp v2 (1.13 KB, patch)
2024-01-31 23:23 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-01-27 20:22:25 UTC 

    


    


      



        
          Comment 1
        

        
          Daniel Engberg

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-27 20:54:55 UTC
        

      






Bring back CMake build as it's needed by future consumers
Adjust Makefile to more closely follow Porters Handbook

Poudriere testport OK 13.2-RELEASE (amd64)
Poudriere testport OK 14.0-RELEASE (amd64)

Tested with following consumers in 14.0-RELEASE (amd64) using Poudriere:
cad/surelog
devel/libantlr4
finance/ledger
games/rlvm
games/vvvvvv
graphics/podofo
net-p2p/transmission-components
science/paraview
science/ttk
textproc/libebml
textproc/lttoolbox
www/rubygem-passenger

    


    


      



        
          Comment 2
        

        
          Daniel Engberg

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-27 20:55:20 UTC
        

      






Created attachment 248019 [details]
Patch for utf8cpp

    


    


      



        
          Comment 3
        

        
          Jason E. Hale

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-29 23:20:01 UTC
        

      






Considering author's rather reluctant stance on CMake [1], I'd recommend not converting to CMake and just keeping the status quo.

[1] https://github.com/nemtrif/utfcpp#installation

    


    


      



        
          Comment 4
        

        
          Daniel Engberg

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-29 23:23:57 UTC
        

      






In that case we need to import/backport https://github.com/taglib/taglib/pull/1218 otherwise it'll fail to build as it can't find utf8cpp.

    


    


      



        
          Comment 5
        

        
          Jason E. Hale

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-29 23:52:13 UTC
        

      






(In reply to Daniel Engberg from comment #4)
I'm fine with that as maintainer of audio/taglib. The author of utf8cpp unfortunately doesn't seem amenable to carrying on further with CMake support, but taglib is dealing with this upstream, as you know. I feel it would be less disruptive to just let it lie.

    


    


      



        
          Comment 6
        

        
          Daniel Engberg

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-01-31 23:23:36 UTC
        

      






Created attachment 248108 [details]
Patch for utf8cpp v2

Drop conversion to CMake as taglib no longer requires CMake files

    


    


      



        
          Comment 7
        

        
          Po-Chuan Hsieh

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-02-13 08:33:54 UTC
        

      






I'll update this port later when I'm available (after catching up with the huge amount of commits).

    


    


      



        
          Comment 8
        

        
          Po-Chuan Hsieh

        

        
            freebsd_committer
            freebsd_triage
        

        
          2024-03-09 17:23:22 UTC
        

      






Updated to 4.0.5 in ports b36bb8a2fa7ee8e8b0f387ec1e1a3a473be47c9c. Thanks.