Bug 277132 - security/py-trezor: drop dependency on blake2
Summary: security/py-trezor: drop dependency on blake2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Emanuel Haupt
URL:
Keywords:
: 277133 (view as bug list)
Depends on:
Blocks: 275494 277135
  Show dependency tree / graph
 
Reported: 2024-02-18 15:09 UTC by Ruslan Makhmatkhanov
Modified: 2024-02-18 17:10 UTC (History)
0 users

See Also:
ehaupt: maintainer-feedback+

Attachments
drop dependency on blake2 (894 bytes, patch)
2024-02-18 15:09 UTC, Ruslan Makhmatkhanov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-02-18 15:09:55 UTC 
Created attachment 248562 [details]
drop dependency on blake2

Dependency on external blake2 implementation was dropped since 0.11.5:
https://github.com/trezor/trezor-firmware/blob/main/python/CHANGELOG.md#changed-10

it is now using implementation from python's hashlib module. So just drop it from Makefile.
Comment 1 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-02-18 15:12:17 UTC 
*** Bug 277133 has been marked as a duplicate of this bug. ***
Comment 2 Emanuel Haupt freebsd_committer freebsd_triage 2024-02-18 17:02:32 UTC 
LGTM, please commit.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-02-18 17:09:27 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=2376f5dc1a11ee9ef35084bd0047ad06a7acd2ae

commit 2376f5dc1a11ee9ef35084bd0047ad06a7acd2ae
Author:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
AuthorDate: 2024-02-18 17:08:06 +0000
Commit:     Ruslan Makhmatkhanov <rm@FreeBSD.org>
CommitDate: 2024-02-18 17:08:06 +0000

    security/py-trezor: drop dependency on blake2

    Dependency on external blake2 implementation was dropped since 0.11.5:
    https://github.com/trezor/trezor-firmware/blob/main/python/CHANGELOG.md#changed-10

    it is now using implementation from python's hashlib module. So just drop it from Makefile.

    PR:             277132
    Approved by:    ehaupt (maintainer)

 security/py-trezor/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 4 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2024-02-18 17:10:12 UTC 
Done, thank you!