I was hoping to test qbittorrent's Bittorrent v2 functionality, but found out that it ships with librasterbar v1. I attempted to compile the port myself, but however when I select librasterbar v2, I get this error in the process: ``` ===> Patching for qbittorrent-4.6.3 ===> Applying extra patch /usr/ports/net-p2p/qbittorrent/files/extrapatch-libtorrent-rasterbar2-settings 1 out of 1 hunks failed--saving rejects to src/base/bittorrent/sessionimpl.cpp.rej ===> FAILED Applying extra patch /usr/ports/net-p2p/qbittorrent/files/extrapatch-libtorrent-rasterbar2-settings *** Error code 1 ``` I see this with 4.6.3 on main, and 4.6.2 on 2024Q1. I do wonder if 4.6.3 should be backported to 2024Q1 as well. I'd also like to ask if librasterbar v2 should become the default, but have no experience with either v1 or v2 so certainly can't say myself. Thank you!
I removed the patch and was able to build 4.6.3 with net-p2p/librasterbar2. So far it seems to be working fine. Not sure what the best approach is here.
Created attachment 248851 [details] net-im/qbittorrent: Fixes libtorrent-rasterbar2 build
Still not sure about if libtorret-rasterbar2 should be the default or not, but the attached patch fixes the build with it. I don't know the intent of the original patch which this removes, so there may be sideffects I don't know about. Initial testing has worked fine for me, however. I did only test this with qbittorrent 4.6.3 and not 4.6.2, but suspect it works with both. I don't think there would be an issue in backporting 4.6.3 to quarterly if that might be a concern.
Hi, https://cgit.freebsd.org/ports/commit/net-p2p/qbittorrent?id=388ecd7ffef779aeb1b8e867c13217c061def9ee should fix your issue as far as I can tell? Best regards, Daniel
Hi Henrich, > Still not sure about if libtorret-rasterbar2 should be the default or not, but the attached patch fixes the build with it. Not until libtorret-rasterbar2 would solve the memory problem. It looks like they change strategy and now mmap all torrent files, which leads to an extremely high memory usage. It's fine to use libtorret-rasterbar2 when your torrents volume is much lower than your RAM, but otherwise torrent client would run in extremely high memory. ---------------- The commit that Daniel pointed out has already fixed the problem that you are reporting here. Please update your ports tree. Thanks, Yuri
Hi Yuri and Daniel, Thank you for the information! That should work. -Henrich