Bug 277269 - [nanoBSD] setting NANO_PMAKE in defaults.sh renders setting NANO_NCPU in config useless
Summary: [nanoBSD] setting NANO_PMAKE in defaults.sh renders setting NANO_NCPU in conf...
Status: New
Alias: None
Product: Base System
Classification: Unclassified
Component: misc (show other bugs)
Version: 14.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-02-23 21:12 UTC by embhd
Modified: 2024-02-23 21:12 UTC (History)
0 users

See Also:

Attachments
Patch (2.69 KB, patch)
2024-02-23 21:12 UTC, embhd 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description embhd 2024-02-23 21:12:53 UTC 
Created attachment 248702 [details]
Patch

As of now, the default value of the variable NANO_PMAKE ("Parallel MAKE") as set in the script `default.sh` contains the default value of NANO_NCPU ("Number of CPUs used").
Thus, if NANO_NCPU is set to a different value in the respective config file, this won't change anything for the actual build, since the value of NANO_PMAKE is not automatically updated to the configured number of cores - rendering the variable more or less useless.

The proposed solution (c.f. the patch attached) is to eliminate the variable NANO_PMAKE and use the "original" variables NANO_MAKE and NANO_NCPU directly, since it only affects two places in `defaults.sh´.

In addition, the patch adds the missing available options to the output of `nanobsd.sh -h`.