Bug 277310 - cad/kicad: patch needed to support opencascade-7.8.0
Summary: cad/kicad: patch needed to support opencascade-7.8.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Thierry Thomas
URL:
Keywords:
Depends on:
Blocks: 277294
  Show dependency treegraph
 
Reported: 2024-02-25 17:19 UTC by Thierry Thomas
Modified: 2024-03-21 18:09 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (cmt)


Attachments
Patch from Johannes Thyssen Tishman (32.30 KB, patch)
2024-02-26 17:54 UTC, Thierry Thomas
thierry: maintainer-approval? (cmt)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thierry Thomas freebsd_committer freebsd_triage 2024-02-25 17:19:43 UTC
If built against opencascade-7.8.0, kicad-7.0.2_5,2 fails with the following error:

-- Found OCC: /usr/local/include/OpenCASCADE (found version "7.8.0") 

*** OpenCascade library missing ***
Could not find a library for TKIGES at /usr/local/lib
Verify your OpenCascade installation or pass CMake
  the library directory as '-DOCC_LIBRARY_DIR=<path>'

CMake Error at cmake/FindOCC.cmake:192 (message):
Call Stack (most recent call first):
  CMakeLists.txt:783 (find_package)


-- Configuring incomplete, errors occurred!
*** Error code 1

Remark: same error in cad/kicad-devel.
Comment 1 Thierry Thomas freebsd_committer freebsd_triage 2024-02-26 17:54:36 UTC
Created attachment 248763 [details]
Patch from Johannes Thyssen Tishman

Johannes Thyssen Tishman proposed a patch for the OpenBSD port, available at <https://www.mail-archive.com/ports@openbsd.org/msg123137.html>.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-03-21 18:03:00 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ea54e4010f3762d05c4bb08fbd0936be88ae417c

commit ea54e4010f3762d05c4bb08fbd0936be88ae417c
Author:     Thierry Thomas <thierry@FreeBSD.org>
AuthorDate: 2024-03-17 14:36:19 +0000
Commit:     Thierry Thomas <thierry@FreeBSD.org>
CommitDate: 2024-03-21 18:01:18 +0000

    cad/kicad: support of OpenCascade 7.8.0

    Patch taken from OpenBSD, by Johannes Thyssen Tishman.

    PR:             277310
    Approved by:    maintainer’s time-out

 cad/kicad/Makefile                                 |  2 +-
 cad/kicad/files/patch-cmake_FindOCC.cmake (new)    | 35 +++++++++++++++++++
 ...on.cmake => patch-cmake_KiCadFullVersion.cmake} |  4 +--
 .../files/patch-eeschema_sim_sim__plot__frame.cpp  |  4 +--
 .../files/patch-job_use_dynamic_cast_for_updating  | 40 ++++++++++------------
 ...atch-pcbnew_import__gfx_dxf__import__plugin.cpp | 12 +++----
 .../files/patch-thirdparty_glew_CMakeLists.txt     |  4 +--
 7 files changed, 66 insertions(+), 35 deletions(-)
Comment 3 Thierry Thomas freebsd_committer freebsd_triage 2024-03-21 18:09:21 UTC
Just committed!