Comment 1 Zsolt Udvari 2024-04-09 14:38:01 UTC

The 2.0.0 is released more than three years ago (https://github.com/aureliojargas/sedsed/tags). Would you like update?

Created attachment 249861 [details]
git diff for devel/sedsed change MASTERSITES, WWW and update to version 1.1

git diff for devel/sedsed

> The 2.0.0 is released more than three years ago
> (https://github.com/aureliojargas/sedsed/tags).
> Would you like update?
This is dogfood (I use it). I use BSD sed for my workflows. Version 2 converts
this to GNU sed. Previous versions support both. Un(til|less) I can provide a
"compatibility" option/patch. I think version 2 may prove to be a bit of a POLA
for it's current user base.
So let's compromise for now, and upgrade to version 1.1; which is the newest
version before the GNU only version (2).

The attached patch accomplishes this. :)

Thanks for taking the time to work on this! :)

--Chris

Comment 3 Zsolt Udvari 2024-04-13 17:42:51 UTC

(In reply to Chris Hutchinson from comment #2)
Okay, understand. In this case could you please add a PORTSCOUT exclude (https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portscout)? And a comment why is it not recommended to update.

Created attachment 249960 [details]
git diff to change MASTERSITES, WWW and update to 1.1 (version 3)

> Okay, understand. In this case could you please add a PORTSCOUT exclude
DONE
> And a comment why is it not recommended to update.
Anyone that discovers that there is a 2.x will discover, as I did, the
removal of BSD sed support. I wouldn't know where to put such an
announcement. That is the sort of thing that belongs in a CHANGELOG.
We don't cater to such things, outside of CHANGES || UPDATING.
IMHO this is better tasked to a pr(1).

Thanks! :)

--Chris

Comment 5 Zsolt Udvari 2024-04-14 08:35:16 UTC

(In reply to Chris Hutchinson from comment #4)
The "announcement" would be a simple comment line (beginning with #) inside the Makefile above the line of PORTSCOUT.

Plus remarks:
The post-extract target is unnecessary and in the do-install can copy ${WRKSRC}/${PORTNAME}.py to ${STAGEDIR}${PREFIX}/bin/sedsed directly.
It's okay to add LICENSE but should set LICENSE_FILE too.
Please check 'portfmt -D Makefile' for some cosmetic changes.

Thanks!

Created attachment 249988 [details]
git diff changing MASTERSITES, WWW, and update to 1.1 (version 4)

> The "announcement" would be a simple comment line (beginning with #)
> inside the Makefile above the line of PORTSCOUT.
Oh. You meant a REMARK/COMMENT. Sure. That makes perfect sense. DONE

> Plus remarks:
> The post-extract target is unnecessary and in the do-install can
> copy ${WRKSRC}/${PORTNAME}.py
> to ${STAGEDIR}${PREFIX}/bin/sedsed directly.
True. But requires modifying SHEBANG_FILES too. DONE

> It's okay to add LICENSE but should set LICENSE_FILE too.
MIT is an already accepted license, out of the box. In fact, I just added
BSD2CLAUSE to that list Friday (#278335). Should be committed soon.
I might also add; the file MIT reads as follows:
The license: MIT (MIT license / X11 license) is standard, please
read from the web.
So even if we wanted to, I think we're out of luck .:)

Please check 'portfmt -D Makefile' for some cosmetic changes.
I use portlint && portclippy. Both gave it the OK. Running portfmt reminded
me on 8 space tabs. Thanks. DONE :)

Thanks for all your time here!

Comment 7 Zsolt Udvari 2024-04-15 05:11:49 UTC

(In reply to Chris Hutchinson from comment #6)
License file: the Porter's Handbook suggests it (https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license - Example 32.). The sedsed's LICENSE contains the name of author too.

Created attachment 249990 [details]
git diff chanhing MASTERSITES, WWW, and updating to 1.1 (version 5)

Sorry. I was a complete idiot. You're completely right.
I had the wrong tab opened in my file browser and looked
the wrong port.
This should satisfy all your nits.

Thanks for all your time on this.

I promise not to be such a PITA next time. :)

--Chris

Comment 9 Zsolt Udvari 2024-04-15 09:17:25 UTC

(In reply to Chris Hutchinson from comment #8)
Thanks!
Did you run portlint? Should insert an empty line between LICENSE* and USES*.

Created attachment 249993 [details]
git diff updating MASTERSITES, WWW and to version 1.1

Well. That's embarrassing.

DONE

Comment 11 Zsolt Udvari 2024-04-16 06:03:31 UTC

Thanks. I changed MASTER_SITES to WWW.
Review: https://reviews.freebsd.org/D44802