Bug 277496 - editors/tamago: Fix build failure and run-time error with latest Emacs 30
Summary: editors/tamago: Fix build failure and run-time error with latest Emacs 30
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Yasuhiro Kimura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-05 02:51 UTC by Yasuhiro Kimura
Modified: 2024-03-27 06:57 UTC (History)
1 user (show)

See Also:
yasu: maintainer-feedback-

Attachments
Patch file (4.66 KB, patch)
2024-03-09 02:44 UTC, Yasuhiro Kimura 		yasu: maintainer-approval? (hrs)
 Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yasuhiro Kimura freebsd_committer freebsd_triage 2024-03-05 02:51:45 UTC 
After editors/emacs-devel is updated to 30.0.50.20240301,3, build of
devel_full and devel_nox flavors fails as following

----------------------------------------------------------------------
if test "/usr/local/bin/emacs-30.0.50" != "no"; then  am__dir=. am__subdir_includes='';  case canna.elc in */*)  am__dir=`echo 'canna.elc' | sed 's,/[^/]*$,,'`;  am__subdir_includes="-L $am__dir -L ./$am__dir";  esac;  test -d "$am__dir" || /bin/mkdir -p "$am__dir" || exit 1;  /usr/local/bin/emacs-30.0.50 --batch  -q -no-site-file -no-init-file  --eval="(setq load-path (append (list (expand-file-name \"..\")) load-path))"  --eval="(load \"docomp.el\")"   $am__subdir_includes -L . -L .  --eval "(defun byte-compile-dest-file (f) \"/tmp/canna.elc\")"  --eval "(unless (byte-compile-file \"canna.el\") (kill-emacs 1))";  if [ -f "/tmp/canna.elc" ]; then  cp /tmp/canna.elc canna.elc && rm -f /tmp/canna.elc;  fi;  else :; fi
Loading /usr0/freebsd/ports/work/usr/ports/editors/tamago/work-devel_nox/tamago-4.0.6.0.20041122.19.15/docomp.el (source)...
Package cl is deprecated

In toplevel form:
canna.el:1:1: Warning: file has no `lexical-binding' directive on its first line
canna.el:33:11: Error: Wrong type argument: obarrayp, [nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil]
*** Error code 1
----------------------------------------------------------------------

If editors/tamago is alreay installed and editors/emacs-devel is
upgraded afterward, following runtime error happens when Tamago is
invoded by typing C-\.

----------------------------------------------------------------------
Wrong type argument: obarrayp, [nil nil nil nil nil nil nil nil nil nil ...]
----------------------------------------------------------------------

And following backtrace is displayed if debugger is enabled with
toggle-debug-on-error.

----------------------------------------------------------------------
Debugger entered--Lisp error: (wrong-type-argument obarrayp [nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil ...])
  intern("　" [nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil ...])
  byte-code("\306\307\310\311\"\311\211\30\31\32\33\13\203H\0\13@@\21\13@A\20\13A\23\10\203C\0\312\313\10@@!\f\"\10@AL\210\312\314\11!\313\10@A!P\15\"\10@@L\210\10A\211\20\204\36\0\n\210\202\13\0,\311\207" [pair lang hash table its-full-half-table its-half-full-table ((Japanese (12288 . 32) (65292 . 44) (65294 . 46) (12289 . 44) (12290 . 46) (65306 . 58) (65307 . 59) (65311 . 63) (65281 . 33) (180 . 39) (65344 . 96) (65342 . 94) (65343 . 95) (65507 . 126) (12540 . 45) (8212 . 45) (8208 . 45) (65295 . 47) (65340 . 92) (12316 . 126) (65372 . 124) (8216 . 96) (8217 . 39) (8220 . 34) (8221 . 34) (65288 . 40) (65289 . 41) (65339 . 91) (65341 . 93) (65371 . 123) (65373 . 125) (12296 . 60) (12297 . 62) (65291 . 43) (8722 . 45) (65309 . 61) (65308 . 60) (65310 . 62) (8242 . 39) (8243 . 34) (65509 . 92) (65284 . 36) (65285 . 37) (65283 . 35) (65286 . 38) (65290 . 42) (65312 . 64) (65296 . 48) (65297 . 49) ...) (Chinese-GB (12288 . 32) (65292 . 44) (65294 . 46) (12289 . 44) (12290 . 46) (65306 . 58) (65307 . 59) (65311 . 63) (65281 . 33) (65344 . 96) (65342 . 94) (65343 . 95) (65507 . 126) (8213 . 45) (65295 . 47) (65340 . 92) (65374 . 126) (65372 . 124) (8216 . 96) (8217 . 39) (8220 . 34) (8221 . 34) (65288 . 40) (65289 . 41) (65339 . 91) (65341 . 93) (65371 . 123) (65373 . 125) (65291 . 43) (65293 . 45) (65309 . 61) (65308 . 60) (65310 . 62) (65287 . 39) (65282 . 34) (65509 . 36) (65285 . 37) (65283 . 35) (65286 . 38) (65290 . 42) (65312 . 64) (65296 . 48) (65297 . 49) (65298 . 50) (65299 . 51) (65300 . 52) (65301 . 53) (65302 . 54) (65303 . 55) ...) (Chinese-CNS (12288 . 32) (65292 . 44) (65294 . 46) (12289 . 44) (12290 . 46) (65306 . 58) (65307 . 59) (65311 . 63) (65281 . 33) (8245 . 39) (8242 . 96) (65087 . 94) (65343 . 95) (8254 . 126) (65123 . 45) (65295 . 47) (65340 . 92) (8725 . 47) (65128 . 92) (8764 . 126) (65372 . 124) (8216 . 96) (8217 . 39) (12317 . 34) (12318 . 34) (8220 . 34) (8221 . 34) (65288 . 40) (65289 . 41) (12308 . 91) (12309 . 93) (65117 . 91) (65118 . 93) (65371 . 123) (65373 . 125) (65115 . 123) (65116 . 125) (12296 . 60) (12297 . 62) (65291 . 43) (65293 . 45) (65309 . 61) (65308 . 60) (65310 . 62) (65284 . 36) (65285 . 37) (65283 . 35) (65286 . 38) (65290 . 42) ...) (Korean (12288 . 32) (65292 . 44) (65294 . 46) (65306 . 58) (65307 . 59) (65311 . 63) (65281 . 33) (8217 . 39) (8216 . 96) (65342 . 94) (65343 . 95) (65507 . 126) (8213 . 45) (173 . 45) (65295 . 47) (65340 . 92) (8764 . 126) (65372 . 124) (8216 . 96) (8217 . 39) (8220 . 34) (8221 . 34) (65288 . 40) (65289 . 41) (65339 . 91) (65341 . 93) (65371 . 123) (65373 . 125) (12296 . 60) (12297 . 62) (65291 . 43) (65293 . 45) (65309 . 61) (65308 . 60) (65310 . 62) (65287 . 39) (65282 . 34) (65510 . 92) (65284 . 36) (65285 . 37) (65283 . 35) (65286 . 38) (65290 . 42) (65312 . 64) (65296 . 48) (65297 . 49) (65298 . 50) (65299 . 51) (65300 . 52) ...)) make-vector 100 nil intern char-to-string symbol-name] 5)
  require(its)
  byte-code("\300\301!\210\300\302!\210\300\303!\210\300\304!\210\300\305!\210\306\307\310\"\207" [require its menudiag egg-mlh egg-cnv egg-com add-hook kill-emacs-hook egg-kill-emacs-function] 3)
  require(egg)
  byte-code("\300\301!\210\300\302!\210\303\304\305\306\307\301%\210\310\311\305\312\307\304\313\314&\7\210\310\315\316\317\307\304\313\320&\7\210\310\321\305\322\307\304\313\323&\7\210\324\325\326\"\207" [require egg egg-edep custom-declare-group anthy-egg nil "Anthy interface for Tamago 4." :group custom-declare-variable anthy-egg-use-utf8 ("/usr/local/share/emacs/30.0.50/site-lisp/egg/egg/anthy.elc" . 86) :type (choice (const :tag "Use UTF8" t) (const :tag "No use UTF8" nil)) anthy-egg-input-method-list '("japanese-egg-anthy") ("/usr/local/share/emacs/30.0.50/site-lisp/egg/egg/anthy.elc" . 138) (repeat (string :format "Input method: %v\n" :size 0)) anthy-egg-use-chinese-korean-server ("/usr/local/share/emacs/30.0.50/site-lisp/egg/egg/anthy.elc" . 183) (choice (const :tag "Use Anthy with Chinese and/or Korean servers" t) (const :tag "No use" nil)) setplist anthy-egg-conversion-backend (egg-start-conversion anthy-egg-convert egg-get-bunsetsu-source anthy-egg-get-bunsetsu-source egg-get-bunsetsu-converted anthy-egg-get-bunsetsu-converted egg-list-candidates anthy-egg-get-candidates egg-decide-candidate anthy-egg-select-candidate egg-change-bunsetsu-length anthy-egg-resize-segment egg-end-conversion anthy-egg-commit egg-special-candidate anthy-egg-special-candidate egg-word-registration anthy-egg-word-registration egg-get-source-language anthy-egg-get-source-language egg-get-converted-language anthy-egg-get-converted-language)] 8)
  egg-activate-anthy("japanese-egg-anthy" its-select-hiragana)
  activate-input-method("japanese-egg-anthy")
  toggle-input-method(nil 1)
  funcall-interactively(toggle-input-method nil 1)
  command-execute(toggle-input-method)
----------------------------------------------------------------------

I investigated the problem and reported it to upstream.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=69536

But they say this isn't bug of Emacs and we should fix the error by
changing source code of Tamago.
Comment 1 Yasuhiro Kimura freebsd_committer freebsd_triage 2024-03-09 02:44:57 UTC 
Created attachment 249043 [details]
Patch file

Fix build of devel_full and devel_nox flavors.
Comment 2 Yasuhiro Kimura freebsd_committer freebsd_triage 2024-03-27 06:52:05 UTC 
Maintainer timeout. Take.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-27 06:56:36 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f8785263c268c1e02f2f04ea24379c9c5c643027

commit f8785263c268c1e02f2f04ea24379c9c5c643027
Author:     Yasuhiro Kimura <yasu@FreeBSD.org>
AuthorDate: 2024-03-09 00:43:10 +0000
Commit:     Yasuhiro Kimura <yasu@FreeBSD.org>
CommitDate: 2024-03-27 06:55:15 +0000

    editors/tamago: Fix build of devel_full and devel_nox flavors

    After editors/emacs-devel is updated to 30.0.50.20240301,3, build of
    devel_full and devel_nox flavors fails as following.

    ----------------------------------------------------------------------
    if test "/usr/local/bin/emacs-30.0.50" != "no"; then  am__dir=. am__subdir_includes='';  case canna.elc in */*)  am__dir=`echo 'canna.elc' | sed 's,/[^/]*$,,'`;  am__subdir_includes="-L $am__dir -L ./$am__dir";  esac;  test -d "$am__dir" || /bin/mkdir -p "$am__dir" || exit 1;  /usr/local/bin/emacs-30.0.50 --batch  -q -no-site-file -no-init-file  --eval="(setq load-path (append (list (expand-file-name \"..\")) load-path))"  --eval="(load \"docomp.el\")"   $am__subdir_includes -L . -L .  --eval "(defun byte-compile-dest-file (f) \"/tmp/canna.elc\")"  --eval "(unless (byte-compile-file \"canna.el\") (kill-emacs 1))";  if [ -f "/tmp/canna.elc" ]; then  cp /tmp/canna.elc canna.elc && rm -f /tmp/canna.elc;  fi;  else :; fi
    Loading /usr0/freebsd/ports/work/usr/ports/editors/tamago/work-devel_nox/tamago-4.0.6.0.20041122.19.15/docomp.el (source)...
    Package cl is deprecated

    In toplevel form:
    canna.el:1:1: Warning: file has no `lexical-binding' directive on its first line
    canna.el:33:11: Error: Wrong type argument: obarrayp, [nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil nil]
    *** Error code 1
    ----------------------------------------------------------------------

    So add patch to fix it.

    PR:             277496
    Approved by:    maintainer timeout

 editors/tamago/files/patch-its.el (new) | 55 +++++++++++++++++++++++++++++++++
 1 file changed, 55 insertions(+)