Bug 277591 - lang/owl-lisp: Use upstream release archive and some minor Makefile improvements
Summary: lang/owl-lisp: Use upstream release archive and some minor Makefile improvements
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-09 07:23 UTC by Daniel Engberg
Modified: 2024-03-21 14:13 UTC (History)
1 user (show)

See Also:
me: maintainer-feedback+

Attachments
Patch for own-lisp (2.21 KB, patch)
2024-03-09 07:23 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-03-09 07:23:02 UTC 
Created attachment 249046 [details]
Patch for own-lisp

- Use upstream release archive as recommended by Porters Handbook
- Don't run tests during build
- Adjust Makefile to improve readability and uniformity

References:
https://gitlab.com/owl-lisp/owl/-/releases
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-03-17 09:47:07 UTC 
Friendly ping
Comment 2 Paco Pascal 2024-03-17 15:58:19 UTC 
Those changes are fine by me. I do not have commit access; therefore, you must commit the patch.

About tests during build, owl-lisp runs tests as part of the build process. For example, building the make target 'bin/ol' invokes tests. I don't see a reason to avoid this.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-19 20:18:29 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=656ecd1c759097f38c155d152331c25dd94df1a8

commit 656ecd1c759097f38c155d152331c25dd94df1a8
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-03-19 20:01:35 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-03-19 20:17:25 +0000

    lang/owl-lisp: Use upstream release archive and some Makefile improvements

    - Use upstream release archive as recommended by Porters Handbook
    - Don't run tests during build
    - Adjust Makefile to improve readability and uniformity

    PR:             277591
    Reviewed by:    Paco Pascal <me@pacopascal.com> (maintainer)

 lang/owl-lisp/Makefile                   | 34 ++++++++++++++------------------
 lang/owl-lisp/distinfo                   |  6 +++---
 lang/owl-lisp/files/patch-Makefile (new) | 11 +++++++++++
 3 files changed, 29 insertions(+), 22 deletions(-)
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-03-19 20:57:07 UTC 
Hi,

"make test" should run tests for consistency with the rest of the tree and due to resource reasons. Another way to look at it would be if all ports ran tests during "make", build times would be several times longer for the complete tree.

Best regards,
Daniel
Comment 5 Paco Pascal 2024-03-21 14:13:06 UTC 
(In reply to Daniel Engberg from comment #4)

Ah, no problem, will do in the future.