Created attachment 249058 [details] Change PREFIX/man to PREFIX/share/man This is the final patch that should go through an exp-run as this involves mass changes in Templates/BSD.local.dist. The exp-run should be initiated after all the ports have been converted or at least a week before the 14.1-RELEASE build starts and should be committed before the release of 14.1-RELEASE. Current list of failed and skipped ports are available here: https://people.freebsd.org/~bofh/dropzone/manprefix-fail.maintainer.txt This file is regularly updated however this update will stop on 13th March as I will need to dedicate my builder on some other build works.
Templates/BSD.local.dist does not look good, both before and after this patch. 1) there are some unneeded uname=root and /set uname=root (unneeed because the owner is already root) 2) since there is no catman anymore and man is no longer setuid, are all the cat directories actually used?
Created attachment 249065 [details] Move man to share/man and fix mtree Hi Antoine, I just remembered our discussion and have fixed the issues with the uname. I have only added the cat directories which were required during my testing and moving man pages. So these specific directories of cat are actually required in share/man.
Autotools ports seem to be dealt with. However, I'd not request exp-run yet but rather start fixing meson ones to reduce the total amount of exp-runs needed.
Apparently, meson doesn't need to be fixed, as it already correctly defaults to --mandir=share/man I'd say, this patch is now ready for an exp-run.
@arrowd I have stopped updating the file at freefall. And thanks for the great work. Hopefully the exp-run will be uneventful.
Before the exp-run, can you check if those ports need fixes? databases/xrootd/pkg-plist devel/papi/pkg-plist devel/dcd-client/pkg-plist devel/gearmand/pkg-plist dns/dnsmasq-devel/pkg-plist lang/icc/files/exclude sysutils/e2fsprogs-core/files/unwanted sysutils/desktop-installer/pkg-plist sysutils/bacula15-server/pkg-plist sysutils/bacula15-server/pkg-plist.client x11-wm/emwm-utils/pkg-plist x11-wm/emwm/pkg-plist
(In reply to Antoine Brodin from comment #6) The list has been dealt with. Before launching an exp-run, am I understanding it right that it will highlight all ports that install manpages to the old location (${PREFIX}/man) ?
(In reply to Gleb Popov from comment #7) Yes it should. This is the same patch that I used to run my mini exp-runs. The exact logics that actually detects the failures are actually not int the patch as it just iterates over the MANDIRS variables. As we are removing the ${PREFIX}/man from the MANDIRS so what will happen is that no man pages will be actually be gzipped anymore if they are not in PREFIX/share/man and eventually will fail with pkg-plist errors.
I just figured I haven't actually requested an exp-run.
Some new failure logs: https://pkg-status.freebsd.org/beefy21/data/140i386-default-foo/2024-04-08_20h33m40s/logs/wesnoth-1.16.12,1.log https://pkg-status.freebsd.org/beefy21/data/140i386-default-foo/2024-04-08_20h33m40s/logs/castxml-0.6.4.log https://pkg-status.freebsd.org/beefy21/data/140i386-default-foo/2024-04-08_20h33m40s/logs/emwm-1.2_1.log
Another one: https://pkg-status.freebsd.org/beefy22/data/140amd64-default-foo/2024-04-08_20h33m59s/logs/errors/hare-lang-0.24.0.log
The fallout has been dealt with. Moin, would you push this yourself?
Not at all. :P Shoot at will please. :)
On another contrary arrowd@ can you discuss with portmgr@ whether if this is actually a right time for this push or not? We have just split quarterly and some stupid people like me will be removing the share/man hacks and in case those needs to be merged quarterly it might break things. So waiting and doing this sometimes near the next quarterly makes sense to me. But yeah I leave it upon portmgr@ to decide and work on this.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=9fd7ee1cdf6cbd5528159b58a966e1a40e2909a9 commit 9fd7ee1cdf6cbd5528159b58a966e1a40e2909a9 Author: Muhammad Moinur Rahman <bofh@freebsd.org> AuthorDate: 2024-04-11 12:32:07 +0000 Commit: Gleb Popov <arrowd@FreeBSD.org> CommitDate: 2024-04-11 18:51:09 +0000 Framework: Finalize switch to share/man for manpages PR: 277603 Approved by: portmgr Mk/bsd.port.mk | 6 +- Templates/BSD.local.dist | 226 +---------------------------------------------- 2 files changed, 4 insertions(+), 228 deletions(-)
Pushed, thanks everyone.
(In reply to Gleb Popov from comment #16) A last one: https://pkg-status.freebsd.org/beefy21/data/140i386-default-foo/2024-04-12_08h38m36s/logs/emwm-utils-1.2_1.log