Created attachment 249089 [details] Patch to 4.2.3 Changelog: https://github.com/sabnzbd/sabnzbd/releases/tag/4.2.3
Created attachment 249117 [details] Patch to 4.2.3 - Change Maintainer Patch looks good to me. Nick has been quick to deliver good patches to keep this port updated after upstream bumps recently. As I don't have quite as much time to keep the port up to date as I did three years ago, I've approached Nick via email about taking over as Maintainer which he is happy to do. Resubmitting the latest patch with MAINTAINER updated to Nick, thanks for taking it on!
Nicholas: please run 'portfmt -D Makefile' (portfmt is part of ports-mgmt/portfmt). Could you please update your patch?
(In reply to Zsolt Udvari from comment #2) And if you add new patch, please use "Obsoletes". Thanks.
Created attachment 249726 [details] Patch to 4.2.3 - v2 Here you go! Thanks for sharing the portfmt tool with me, I'm fairly new to this.
(In reply to Nicholas Kirby from comment #4) Please share only one patch, against the ports tree. Now there are two patch, one is an update to 4.2.3 and other is cosmetic changes. Could you please merge into one patch? Thanks!
Created attachment 249750 [details] Patch to 4.2.3 - v3 Sorry again! How is this? It's a valuable lesson to me to actually READ it before I submit it. Thanks again!
(In reply to Nicholas Kirby from comment #6) Something wrong, I can't "git apply": # fetch -q 'https://bz-attachments.freebsd.org/attachment.cgi?id=249750' -o - | git apply error: corrupt patch at line 12 The patch utility says similar error: # fetch -q 'https://bz-attachments.freebsd.org/attachment.cgi?id=249750' -o - | patch -N Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |diff --git a/news/sabnzbd/Makefile b/news/sabnzbd/Makefile |index 6eb3eda5c..e4680e881 100644 |--- a/news/sabnzbd/Makefile |+++ b/news/sabnzbd/Makefile -------------------------- Patching file news/sabnzbd/Makefile using Plan A... patch: **** malformed patch at line 12: Could you please fix it? The "git diff --output sabnzbd.diff" would be fine (maybe as you did?).
Created attachment 249752 [details] Patch to 4.2.3 - v4 Alright, how is this? I had to fix a couple of mistakes I made between my ports tree and my poudriere tree but I think this should be good! Thanks again
(In reply to Nicholas Kirby from comment #8) Same error. Maybe you should try apply your patch on a clean ports tree (git apply).
Created attachment 249846 [details] Patch to 4.2.3 - v5 Alright! I'm 99% sure I've got it this time. I made SEVERAL mistakes with previous patches! - I had a ^M blank space at the end of every line of the previous one that was the result of how I tried to be lazy and copy the raw text to another machine for upload. I've set up a basic file share so I can get the actual tested file from my main machine for upload so it can't be adulterated before upload. - I was building my patch in my poudriere default ports tree and not my actual ports tree so it would apply to the poudriere one and not the main one with git apply. I'm no longer doing that. The one I am uploading I have tested applying to my normal ports tree and it works (for me)! Thank you again for your patience. P.S. Ha ha ha after all that I filled in this box and didn't actually attach the file. Got a big ol' RED ERROR MESSAGE.
(In reply to Nicholas Kirby from comment #10) Okay, now can apply :) I'm testing and I'll open a review. Thanks.
Remarks: - the COPYRIGHT.TXT in PORTDOCS, should be the LICENSE_FILE instead (see https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license and https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license_file) - I can't find BSD2CLAUSE, BSD3CLAUSE, ISCL, PSFL in the source files, maybe should remove them? - maybe can use msgfmt (part of gettext-tools) to generate *.mo files instead of extracted msgfmt.py - sabnbzd/utils/pybonjour.py: there is a package, py-pybonjour. Should use it: https://docs.freebsd.org/en/books/porters-handbook/book/#bundled-libs - sabnbzd/utils/rarfile.py: same as above - the sabnzbd/utils/systrayiconthread.py has WTFPL license, should include into LICENSES
Created attachment 250075 [details] Patch to 4.2.3 - v6 Alright, sorry about the delay. How is this? I might need some coaching on how to get it to use gettext-tools, as my build log is seeing it as a dependency and installing it. Not sure how it generates the .mo files though.