Bug 277676 - lang/ocaml-nox11: remove redundant port
Summary: lang/ocaml-nox11: remove redundant port
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Guido Falsi
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-13 21:43 UTC by Benjamin Jacobs
Modified: 2024-04-11 10:23 UTC (History)
3 users (show)

See Also:
madpilot: maintainer-feedback-

Attachments
0001-lang-ocaml-nox11-Remove-redundant-port.patch (2.27 KB, patch)
2024-03-13 21:46 UTC, Benjamin Jacobs 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Jacobs 2024-03-13 21:43:23 UTC 
X11 support has been expunged from lang/ocaml. This port is functionnaly identical to the master port now, hence it is useless. Attaching a patch.
Comment 1 Benjamin Jacobs 2024-03-13 21:46:45 UTC 
Created attachment 249138 [details]
0001-lang-ocaml-nox11-Remove-redundant-port.patch
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2024-03-13 21:55:21 UTC 
Put correct maintainer in maintainer-feedback field.
Comment 3 Benjamin Jacobs 2024-03-13 22:09:48 UTC 
Actually lang/ocaml-nox11 has a different MAINTAINER= than lang/ocaml. I guess that lang/ocaml Makefile should probably have used MAINTAINER?= instead of =, but that will be a non bug soon :). In any case, it can wait for a timeout.
Comment 4 Benjamin Jacobs 2024-03-13 22:20:42 UTC 
By the way, lang/ocaml will need a small cleanup afterward to remove the PKGNAMESUFFIX=${SFX} line. It may be that such no-op cleanup change might not require a maintainer approval, but I've left out the attached patch. /fwiw
Comment 5 Guido Falsi freebsd_committer freebsd_triage 2024-03-15 08:27:01 UTC 
Fix maintainer address. Sorry for the mistake!
Comment 6 Guido Falsi freebsd_committer freebsd_triage 2024-04-10 15:51:14 UTC 
Maintainer timed out.
Comment 7 commit-hook freebsd_committer freebsd_triage 2024-04-10 16:21:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=68c4464c9aac2ea0822548086150db97a29776fb

commit 68c4464c9aac2ea0822548086150db97a29776fb
Author:     Benjamin Jacobs <freebsd@dev.thsi.be>
AuthorDate: 2024-04-10 16:15:30 +0000
Commit:     Guido Falsi <madpilot@FreeBSD.org>
CommitDate: 2024-04-10 16:19:22 +0000

    lang/ocaml-nox11: Remove redundant sub port

    X11 support has been removed upstream from ocaml, menaing the UI
    support in the ocaml compiler.

    Ability to compile ports with X11 UI is supported and depends on
    other components available in the ports tree.

    So remove this redundant port since the provided functionality is
    identical to the lang/ocaml port.

    PR:             277676
    Approved by:    michael.grunewald@laposte.net (maintainer timeout)

 MOVED                            |  1 +
 lang/Makefile                    |  1 -
 lang/ocaml-nox11/Makefile (gone) | 15 ---------------
 3 files changed, 1 insertion(+), 16 deletions(-)
Comment 8 Guido Falsi freebsd_committer freebsd_triage 2024-04-10 16:21:52 UTC 
Committed. Thanks!
Comment 9 Benjamin Jacobs 2024-04-11 10:23:49 UTC 
Cool, thank you!