Bug 277753 - audio/libdjinterop: Various improvements
Summary: audio/libdjinterop: Various improvements
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Charlie Li
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-17 05:47 UTC by Daniel Engberg
Modified: 2024-03-18 20:57 UTC (History)
0 users

See Also:
vishwin: maintainer-feedback+


Attachments
Patch for libdjinterop (1.99 KB, patch)
2024-03-17 05:47 UTC, Daniel Engberg
vishwin: maintainer-approval-
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-03-17 05:47:12 UTC
Created attachment 249234 [details]
Patch for libdjinterop

* Backport upstream patch deeb55cc8cf9abed30629507565343e4dbd32e97 to remove hardcoding of -stdlib=libc++
* Backport upstream patch to remove hardcoding of -O3 optimization
  Porters Handbook, https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags
* Define Boost library as a dependency for "make test"
* Sort USES= and add missing USES= pathfix (reported by framework)
* Add USE_LDCONFIG
* Disable build of unit tests unless requested even if Boost libs are available

Unit tests still fails, is that intentional? If not please put a note somewhere about in commit msg or Makefile and report upstream
Comment 1 Charlie Li freebsd_committer freebsd_triage 2024-03-18 12:41:41 UTC
Comment on attachment 249234 [details]
Patch for libdjinterop

Unit tests failing are intentional. Upstream don't even run them properly (as in, at all) in their own CI, so their "passes" are illusions.

I'm not moving the boost dependency out of BUILD_DEPENDS. CMakeLists.txt is unfortunately specifically structured such that test programs are only built and available when boost is available at configure time, and it's not worth the extra burden to hack our Makefile to avoid it.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-03-18 20:57:13 UTC
At least when I briefly tested it on my dev box it seemed to pick up boost during do-test, it might be a side-effect due to how do-test is defined with USES= cmake:testing is used.

I haven't looked at upstreams Makefile though if it works by accident.