Created attachment 249375 [details] v0 (apply via `git am`)
Created attachment 249376 [details] poudriere build -t log (qt5 flavor)
Created attachment 249377 [details] poudriere build -t log (qt6 flavor)
Few points here (though no blockers): 1. I was trying to switch default flavor by using '${FLAVORS:[2]}', but poudriere had issues, so opened bug #277865 for that. 2. I was thinking on adding TEST_DEPENDS to cpp-httplib on 14+. However, this would be meaningful only if it will be not satisfy-or-fail dependency, but satisfy-or-ignore one, which isn't the case (correct me if I'm wrong).
(In reply to Anton Saietskii from comment #3) The first flavour in the list *must* be the default flavour. Change the order of flavours in the list to change the default flavour. As for TEST_DEPENDS, these are only checked for if you run "make test". So adding extra stuff in there that's not normally needed is fine.
(In reply to Robert Clausecker from comment #4) Regarding the flavors: For me, it seems more natural to use LTR ascending order in definitions -- that was the reason trying to set not 1st as default. Ports tree doesn't have problems with that (tested and confirmed), only poudriere has. - Anyway, this is already set as per agreement -- qt6 is first and default. - And for TEST_DEPENDS, let me put a bit more context here: tremotesf can use cpp-httplib<=0.15.x (which is explicitly set in CMakeLists.txt), so it's possible to set TEST_DEPENDS=cpp-httplib<=0.15:www/cpp-httplib (of course, not for 13 where it's broken). However, cpp-httplib is in early and very active stage of development, so for example tomorrow 0.16.x may be pushed to ports, which will break 'make test' target due to unsatisfied dependency, unless ports have an option "register dependency, but ignore and de-register if satisfying fails" (didn't hear if it's possible). Thus, I came to conclusion it's just simpler and makes more sense to bundle cpp-httplib 0.14.3, which is one of supported versions and works on 13.x-R, 14.x-R.
(In reply to Anton Saietskii from comment #5) Hi Anton. This choice seems reasonable. I'll look into processing this patch with my next batch.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=de05cf874d6a6f118cc2a95d1513ce63029f5c94 commit de05cf874d6a6f118cc2a95d1513ce63029f5c94 Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2024-03-21 14:59:30 +0000 Commit: Robert Clausecker <fuz@FreeBSD.org> CommitDate: 2024-03-28 09:50:03 +0000 net-p2p/tremotesf: Update to 2.6.1 While here, switch default flavor to Qt 6 to be consistent with upstream. PR: 277867 net-p2p/tremotesf/Makefile | 9 +++++---- net-p2p/tremotesf/distinfo | 6 +++--- 2 files changed, 8 insertions(+), 7 deletions(-)
Thank you for your contribution.