Bug 277915 - exp-run: Base + ports changes related to POSIX_VERSION
Summary: exp-run: Base + ports changes related to POSIX_VERSION
Status: In Progress
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Warner Losh
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-24 11:07 UTC by Warner Losh
Modified: 2024-03-31 13:49 UTC (History)
5 users (show)

See Also:
antoine: exp-run+

Attachments
ports git-format-patch changes (8.43 KB, patch)
2024-03-24 11:07 UTC, Warner Losh 		no flags Details | Diff
src git-fromat-patch for the run (1.99 KB, patch)
2024-03-24 11:08 UTC, Warner Losh 		no flags Details | Diff
Optimized patch for ports security/openssl{,-quictls,111,31,31-quictls,32,33} (6.75 KB, patch)
2024-03-30 17:51 UTC, Vladimir Druzenko 		brnrd: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Warner Losh freebsd_committer freebsd_triage 2024-03-24 11:07:56 UTC 
Created attachment 249443 [details]
ports git-format-patch changes

I want to bump the BASE's POSIX_VERSION to 200809L, which I believe we support completely (or nearly so).

Trouble is, this breaks OpenSSL in a trivial way. I have a patch for base, but also included patches for the ports which I've only compile tested (though given the code's history I'm changing, it's sufficient).

This bug has two patches: one for base and one for ports. I've not made the ports patches pretty, but have attended to the PORTREVISION bumping detail. I've made my best stab at it, though, so constructive criticism welcome.
Comment 1 Warner Losh freebsd_committer freebsd_triage 2024-03-24 11:08:28 UTC 
Created attachment 249444 [details]
src git-fromat-patch for the run
Comment 2 Warner Losh freebsd_committer freebsd_triage 2024-03-24 11:08:56 UTC 
Requesting an exp run (I hope I did this right).
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-25 19:26:23 UTC 
I think we can commit patches to security/openssl* before exp-run start.
Added brnrd@ to CC (maintainer of the security/openssl*).
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2024-03-29 16:06:55 UTC 
Exp-run looks fine
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-30 14:35:23 UTC 
brnrd, do you approve patches for security/openssl*?
Can I commit or can you commit?
Comment 6 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-30 16:33:22 UTC 
Typo in security/openssl33/Makefile:
-PATCHREVISION=	1
+PORTREVISION=	1

Reported by arrowd.
Comment 7 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-30 16:36:20 UTC 
Also do security/openssl (3.0.x) need this patch too?
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-30 17:04:57 UTC 
security/openssl31-quictls, security/openssl-quictls.
Comment 9 Vladimir Druzenko freebsd_committer freebsd_triage 2024-03-30 17:51:08 UTC 
Created attachment 249580 [details]
Optimized patch for ports security/openssl{,-quictls,111,31,31-quictls,32,33}

Check this patch.
Comment 10 Warner Losh freebsd_committer freebsd_triage 2024-03-30 19:47:10 UTC 
(In reply to Vladimir Druzenko from comment #7)
> Also do security/openssl (3.0.x) need this patch too?

Yes. All versions > 1.1 will need them (and maybe more). I've submitted the change upstream, but it hasn't landed there yet. I don't knkow their plans for backporting.

https://github.com/openssl/openssl/pull/23885
Comment 11 Warner Losh freebsd_committer freebsd_triage 2024-03-30 19:51:30 UTC 
I'm planning on committing the POSIX_VERSION bump soon to src -current, and likely a MFC to 14.x (and maybe 13.x). My compliance analysis suggests that 14.x is at the same level as -current.

This change should ideally land before the quarterly branch, but could also be merged if we miss that. Once it's in both places, I'll move forward with the bump in -current. I plan on updating -current's openssl with this patch early next week, modified like upstream made me... But I need to coordinate with cy@ (cc'd).
Comment 12 Bernard Spil freebsd_committer freebsd_triage 2024-03-31 12:56:34 UTC 
Comment on attachment 249580 [details]
Optimized patch for ports security/openssl{,-quictls,111,31,31-quictls,32,33}

Thanks! I'm committing this today.