Bug 277929 - www/py-django-tagging: Add compatibility for Django 4.2
Summary: www/py-django-tagging: Add compatibility for Django 4.2
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kai Knoblich
URL: https://github.com/Fantomas42/django-...
Keywords:
Depends on:
Blocks: 276319
  Show dependency tree / graph
 
Reported: 2024-03-24 17:17 UTC by Kai Knoblich
Modified: 2024-03-27 05:47 UTC (History)
1 user (show)

See Also:
ports: maintainer-feedback+

Attachments
py-django-tagging-add-dj42-compatibility.patch (1.89 KB, patch)
2024-03-24 17:17 UTC, Kai Knoblich 		ports: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Knoblich freebsd_committer freebsd_triage 2024-03-24 17:17:37 UTC 
Created attachment 249454 [details]
py-django-tagging-add-dj42-compatibility.patch

Hi,

attached is a patch that adds compatibility for Django 4.2 (remaining bits of the pull request #23 at the upstream repository).

Without the patch, py-django-tagging emits following error with Django 4.2:

> [...]
>   File "<frozen importlib._bootstrap>", line 228, in _call_with_frames_removed
>   File "/usr/local/lib/python3.9/site-packages/tagging/models.py", line 9, in <module>
>     from django.utils.encoding import smart_text
> ImportError: cannot import name 'smart_text' from 'django.utils.encoding' (/usr/local/lib/python3.9/site-packages/django/utils/encod
ing.py)


QA:
~~~
- poudriere -> OK (13.2-RELEASE amd64, py38 - py311)
Comment 1 Kevin Golding 2024-03-25 08:46:53 UTC 
Comment on attachment 249454 [details]
py-django-tagging-add-dj42-compatibility.patch

wfm, thanks
Comment 2 Kevin Golding 2024-03-25 08:47:42 UTC 
Looks good, thanks
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-03-27 05:40:26 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=52e2b209b284ecc9e1ef29f7fcb3ab2cc8219b77

commit 52e2b209b284ecc9e1ef29f7fcb3ab2cc8219b77
Author:     Kai Knoblich <kai@FreeBSD.org>
AuthorDate: 2024-03-27 05:37:20 +0000
Commit:     Kai Knoblich <kai@FreeBSD.org>
CommitDate: 2024-03-27 05:38:17 +0000

    www/py-django-tagging: Add Django 4.2 compatibility

    * Bump PORTREVISION due package change.

    PR:             277929
    Approved by:    Kevin Golding (maintainer)

 www/py-django-tagging/Makefile                      |  2 +-
 www/py-django-tagging/files/patch-tagging_models.py | 20 +++++++++++++++++---
 2 files changed, 18 insertions(+), 4 deletions(-)
Comment 4 Kai Knoblich freebsd_committer freebsd_triage 2024-03-27 05:47:37 UTC 
(In reply to Kevin Golding from comment #2)

Committed, thank you for your swift review and feedback!