Bug 277935 - net/py-ripe.atlas.sagan: Update to 1.3.1
Summary: net/py-ripe.atlas.sagan: Update to 1.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL: https://github.com/RIPE-NCC/ripe-atla...
Keywords: needs-patch, needs-qa
Depends on: 278522
Blocks: 277936
  Show dependency treegraph
Reported: 2024-03-24 21:08 UTC by Marek Zarychta
Modified: 2024-05-07 11:30 UTC (History)
3 users (show)

See Also:
zarychtam: maintainer-feedback?

upgrade patch (1.79 KB, patch)
2024-03-24 21:08 UTC, Marek Zarychta
zarychtam: maintainer-approval-
Details | Diff
v0: pep517, pytest (1.59 KB, patch)
2024-04-11 09:12 UTC, Nuno Teixeira
eduardo: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marek Zarychta 2024-03-24 21:08:46 UTC
Created attachment 249458 [details]
upgrade patch

net/py-ripe.atlas.sagan: Update to 1.3.1
    - Update port to the most recent version
    - Change from PyPI to GitHub
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2024-03-24 21:08:46 UTC
Maintainer informed via mail
Comment 2 Max Stucchi 2024-04-09 18:20:21 UTC
Looks good!
Comment 3 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-10 09:13:09 UTC
Why changing from pypi to github?
Comment 4 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-10 17:28:14 UTC
Reopening, PR is open and waiting on upstream to proceed.
Comment 5 Marek Zarychta 2024-04-10 18:59:36 UTC
Comment on attachment 249458 [details]
upgrade patch

Undesired, spurious change from PyPi to GitHub
Comment 6 Nuno Teixeira freebsd_committer freebsd_triage 2024-04-11 09:12:18 UTC
Created attachment 249895 [details]
v0: pep517, pytest

- Use pep517 build
- Add pytest tests
Comment 7 Marek Zarychta 2024-05-06 09:30:40 UTC
Ports committer Nuno Teixeira stepped in rejecting the original patch and demanding from the upstream to send sources to PyPi. After the upstream fulfilled request, the committer created new patch rebased on PyPi sources, but did not commit it, instead escalated requesting the change of maintainer's email address.
As a reporter I am closing the PR since original patch was rejected. The port in current state is not functional and should be marked as BROKEN. Please submit new PR if you want to update the port.
Comment 8 Nuno Teixeira freebsd_committer freebsd_triage 2024-05-07 07:35:29 UTC
Reopening, reset maintainer completed.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-05-07 11:28:27 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=f41c8d6955ade7a6cf29c2b0253fd3eecf99ab54

commit f41c8d6955ade7a6cf29c2b0253fd3eecf99ab54
Author:     Nuno Teixeira <eduardo@FreeBSD.org>
AuthorDate: 2024-05-07 11:22:27 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-05-07 11:22:27 +0000

    net/py-ripe.atlas.sagan: Update to 1.3.1

    - Switch to DISTVERSION
    - Use pep517 build
    - Add pytest tests
    - Take maintainership for the time being

    ChangeLog: https://github.com/RIPE-NCC/ripe-atlas-sagan/releases/tag/v1.3.1

    PR:             277935
    Reported by:    Marek Zarychta <zarychtam@plan-b.pwste.edu.pl>

 net/py-ripe.atlas.sagan/Makefile | 13 +++++++++----
 net/py-ripe.atlas.sagan/distinfo |  6 +++---
 2 files changed, 12 insertions(+), 7 deletions(-)
Comment 10 Nuno Teixeira freebsd_committer freebsd_triage 2024-05-07 11:30:45 UTC
Committed, thanks!