Created attachment 249497 [details] Fix KUBERNETES/SSH option handling In a nutshell, there's a) a conflict in configure args caused by having "<opt>_CONFIGURE_WITH= pango terminal" for both of these options and b) pkg-plist unconditionally listing libterm-related files which are only built/installed when one of these options is selected See attached patch for my proposed fix. No bump, just fixes non-default options without changing anything for what worked before.
Comment on attachment 249497 [details] Fix KUBERNETES/SSH option handling lgtm. Can't recall why those were added as deps. They were probably required at some point long ago.
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=e760c81810bf72c06194543cee14207911aaf988 commit e760c81810bf72c06194543cee14207911aaf988 Author: Felix Palmen <zirias@FreeBSD.org> AuthorDate: 2024-03-23 06:26:43 +0000 Commit: Felix Palmen <zirias@FreeBSD.org> CommitDate: 2024-04-01 06:10:37 +0000 net/guacamole-server: Fix disabling KUBERNETES/SSH Both options need --with-pango and --with-terminal configure args. The <opt>_CONFIGURE_WITH helper also adds --without-* args for disabled options, so it can't be used here, as this will lead to conflicting configure args. Solve this by explicitly handling these after including bsd.port.options.mk. Also fix pkg-plist when both KUBERNETES and SSH are disabled. PR: 277976 Approved by: ultima (maintainer) net/guacamole-server/Makefile | 18 ++++++++++++------ net/guacamole-server/pkg-plist | 10 +++++----- 2 files changed, 17 insertions(+), 11 deletions(-)
Thanks, fix committed!