Bug 278050 - devel/gettext-tools: 0.22.5 crashes in WITH_TESTING=yes enabled self-tests in poudriere bulk builds - please fix
Summary: devel/gettext-tools: 0.22.5 crashes in WITH_TESTING=yes enabled self-tests in...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Tijl Coosemans
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-03-30 12:48 UTC by Matthias Andree
Modified: 2024-03-30 18:58 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (tijl)


Attachments
patch-gnulib-tests_test-execute-main.c (264 bytes, patch)
2024-03-30 17:04 UTC, Tijl Coosemans
no flags Details | Diff
files/patch-gnulib-tests_test-time.c -- patch to SKIP test-time (319 bytes, patch)
2024-03-30 18:54 UTC, Matthias Andree
no flags Details | Diff
zstd-compressed FreeBSD 14.0 amd64 poudriere-devel build log (84.56 KB, application/x-zstd-compressed)
2024-03-30 18:58 UTC, Matthias Andree
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Andree freebsd_committer freebsd_triage 2024-03-30 12:48:54 UTC
The abort() in test-time looks scary, but I get it only in a jail, not on a plain running FreeBSD 14.0 amd64.

Assertion failure? Incompatibility? 

[00:04:40] PASS: test-dup
[00:04:40] PASS: test-dup2
[00:04:40] PASS: test-environ
[00:04:40] PASS: test-errno
[00:04:40] PASS: test-error.sh
[00:04:41] FAIL: test-execute.sh
[00:04:41] PASS: test-execute-script
[00:04:41] PASS: test-fabs
[00:04:41] PASS: test-fchdir
[00:04:41] PASS: test-fcntl-h
[00:04:41] PASS: test-fcntl
--
[00:05:12] PASS: test-init.sh
[00:05:12] PASS: test-thread_self
[00:05:12] PASS: test-thread_create
[00:05:12] PASS: test-time-h
[00:05:13] Abort trap (core dumped)
[00:05:13] FAIL: test-time
[00:05:13] PASS: test-timespec
[00:05:14] PASS: test-tls
[00:05:14] PASS: test-trim1.sh
[00:05:14] PASS: test-trim2.sh
[00:05:14] PASS: test-trim3.sh
--
[00:05:18] Testsuite summary for gettext-tools 0.22.5
[00:05:18] ============================================================================
[00:05:18] # TOTAL: 395
[00:05:18] # PASS:  358
[00:05:18] # SKIP:  35
[00:05:18] # XFAIL: 0
[00:05:18] # FAIL:  2
[00:05:18] # XPASS: 0
[00:05:18] # ERROR: 0
[00:05:18] ============================================================================
[00:05:18] See gnulib-tests/test-suite.log
[00:05:18] Please report to bug-gettext@gnu.org
Comment 1 Tijl Coosemans freebsd_committer freebsd_triage 2024-03-30 17:04:09 UTC
Created attachment 249579 [details]
patch-gnulib-tests_test-execute-main.c

Putting this patch in devel/gettext-tools/files fixes test-execute.sh for me.
Comment 2 Tijl Coosemans freebsd_committer freebsd_triage 2024-03-30 17:10:58 UTC
It only failed with poudriere bulk, not with testport.  I suspect bulk installs a signal handler for SIGINT and that this leaks to child processes somehow.  So poudriere developers should look into this before I commit the attached patch.

test-time doesn't fail here.
Comment 3 Tijl Coosemans freebsd_committer freebsd_triage 2024-03-30 17:31:30 UTC
test-time tests whether time() and gettimeofday() are consistent.  time() is implemented using clock_gettime(CLOCK_SECOND,...) and the man page for clock_gettime says CLOCK_SECOND "returns the current second without performing a full time counter query, using an in-kernel cached value of the current second," which means this test may fail sporadically.  Maybe the test should be skipped on FreeBSD.
Comment 4 Matthias Andree freebsd_committer freebsd_triage 2024-03-30 18:54:21 UTC
Created attachment 249583 [details]
files/patch-gnulib-tests_test-time.c -- patch to SKIP test-time

How about this patch to skip the test-time?
Comment 5 Matthias Andree freebsd_committer freebsd_triage 2024-03-30 18:55:55 UTC
With both patches in files/, my poudriere bulk build now passes.
Comment 6 Matthias Andree freebsd_committer freebsd_triage 2024-03-30 18:58:07 UTC
Created attachment 249584 [details]
zstd-compressed FreeBSD 14.0 amd64 poudriere-devel build log

attaching also my poudriere log