Bug 278159 - net/samba419 Shadow copy (zfs) can't seem to restore deleted file (4.13 broken, 4.16 fixed, 4.19 broken)
Summary: net/samba419 Shadow copy (zfs) can't seem to restore deleted file (4.13 broke...
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Only Me
Assignee: Mikael Urankar
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-04 07:26 UTC by Duncan
Modified: 2024-04-22 16:10 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (mikael)

Attachments
v0 (18.08 KB, patch)
2024-04-04 11:29 UTC, Mikael Urankar 		no flags Details | Diff
v1 (2.25 KB, patch)
2024-04-09 12:37 UTC, Mikael Urankar 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Duncan 2024-04-04 07:26:56 UTC 
Behavior that was fixed from 4.13 -> 4.16 but has been undone going to 4.19.

I'm running file servers at 3 sites, inside FreeBSD 14.0 jails running on zfs. They are domain members and use acls. They perform failover via windows DFS.  They are kept in sync via syncthing.

I have hourly snapshots during the day which are integrated with shadow copies. As part of this job, I need to do an "ls /bastille/jails/server/root/smb_shares/*/.zfs/snapshot" on the host. If I don't, the snapshots don't seem to be detected. I am fine with this.

My problem, which was apparent in 4.13 and disappeared in 4.16, is that if a file is deleted, it is visible in the "previous versions", but when I try to copy it back, I get a "Could not find this item.  This is no longer located in Z:\....\dir. Verify the item's location and try again".

Unfortunately this behavior has returned in 4.19.
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2024-04-04 11:29:33 UTC 
Created attachment 249702 [details]
v0

Can you test the attached patch, it should restore the 4.16 behavior
Comment 2 Duncan 2024-04-05 08:42:52 UTC 
The patch worked.

Many thanks.
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2024-04-09 12:37:57 UTC 
Created attachment 249848 [details]
v1

The previous patch broke acls on zfs.
Can you give this one a shot? It also update samba to 4.19.6
Thanks.