Created attachment 249850 [details] v0 (apply via `git am`) It's a bugfix-only release: Fixed * Application being closed when opening file picker in Qt 6 builds Actual change is just 'QCoreApplication::setQuitLockEnabled(false);' call, thus I'm requesting merge to quarterly branch.
Created attachment 249851 [details] poudriere build -t log (qt5 flavor)
Created attachment 249858 [details] poudriere build -t log (qt6 flavor)
Could you please check 'portclippy Makefile'? (part of ports-mgmt/portfmt package) Thanks!
(In reply to Zsolt Udvari from comment #3) Of course I'm doing that (along with portfmt & portlint) on each op change. Unfortunately, portclippy doesn't handle '.if' properly: for example, it suggests moving CMAKE_OFF below CMAKE_ARGS, what isn't really possible -- first variable is specific to flavor, while second is for port regardless of flavor. If we'll move entire '.if' block below CMAKE_ARGS -- portclippy will complain about USE_QT and USE_GL (and these variables can't be moved to suggested places as well). So, no matter how one will reroll makefile (keeping '.if' block) -- portclippy will complain about different variables until it will learn to process conditionals as a subblock, which in turn can contain its own USES, USE_*, etc blocks.
(In reply to Anton Saietskii from comment #4) Sorry, you've right. I saw your diff some days ago and I notice this but I forget it.
(In reply to Zsolt Udvari from comment #5) Created bug #278591 for that.
I'll commit when mentor(s) approve it (https://reviews.freebsd.org/D44981).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=1752db72ddd89f09363a4688342d1b5039fc9e44 commit 1752db72ddd89f09363a4688342d1b5039fc9e44 Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2024-04-27 05:22:30 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-04-29 12:08:40 +0000 net-p2p/tremotesf: update to 2.6.2 Add compiler:c++20-lang to USES. Changelog: https://github.com/equeim/tremotesf2/releases/tag/2.6.2 PR: 278274 Approved by: Submitter is maintainer, diizzy (mentor) Differential Revision: https://reviews.freebsd.org/D44981 net-p2p/tremotesf/Makefile | 5 +++-- net-p2p/tremotesf/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-)
Committed, thanks!
(In reply to Zsolt Udvari from comment #9) Zsolt, I'm afraid you forgot about quarterly. 2.6.2 is a bugfix-only release, which fixes crash in 2.6.1, which in turn is in quarterly now.
A commit in branch 2024Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3e07ec5fc79aeba1f97c38c375d5291d2e5066db commit 3e07ec5fc79aeba1f97c38c375d5291d2e5066db Author: Anton Saietskii <vsasjason@gmail.com> AuthorDate: 2024-04-27 05:22:30 +0000 Commit: Zsolt Udvari <uzsolt@FreeBSD.org> CommitDate: 2024-04-29 17:41:17 +0000 net-p2p/tremotesf: update to 2.6.2 Add compiler:c++20-lang to USES. Changelog: https://github.com/equeim/tremotesf2/releases/tag/2.6.2 PR: 278274 Approved by: Submitter is maintainer, diizzy (mentor) Differential Revision: https://reviews.freebsd.org/D44981 (cherry picked from commit 1752db72ddd89f09363a4688342d1b5039fc9e44) net-p2p/tremotesf/Makefile | 5 +++-- net-p2p/tremotesf/distinfo | 6 +++--- 2 files changed, 6 insertions(+), 5 deletions(-)
(In reply to Anton Saietskii from comment #10) Sorry, I forget it. Done. Thanks!