Bug 278384 - net/frr10: new port
Summary: net/frr10: new port
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-04-15 19:07 UTC by Kurt Jaeger
Modified: 2024-04-17 16:15 UTC (History)
2 users (show)

See Also:


Attachments
patch-for-frr10 (19.65 KB, patch)
2024-04-15 19:07 UTC, Kurt Jaeger
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kurt Jaeger freebsd_committer freebsd_triage 2024-04-15 19:07:58 UTC
Created attachment 249996 [details]
patch-for-frr10

Attached is net/frr10 port. It builds, but it probably needs more testing.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-04-17 16:15:56 UTC
PORTVERSION --> DISTVERSION
https://docs.freebsd.org/en/books/porters-handbook/book/#porting-makefile
See also "Table 2. Package Naming Examples" in Porters Handbook

post-patch and do-install sections when building slave port should be moved in Makefile should be move to proper location(s)
Frequently occurring issue with the slave port parts

post-patch changes should perferably be pre-patched,
see https://cgit.freebsd.org/ports/tree/net-mgmt/netdata/Makefile#n84

.else statements are unnecessary, just close the if statement

CPPFLAGS are probably meant to be CXX and both CXX and LDFLAGS can (and should) be replaced by USES= localbase:ldflags
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

CONFIGROLLBACKS_LIB_DEPENDS=	libsqlite3.so:databases/sqlite3
Should be using USES= sqlite

Best regards,
Daniel