Bug 278698 - devel/open62541: Update to version 1.4.0
Summary: devel/open62541: Update to version 1.4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Daniel Engberg
URL: https://github.com/open62541/open6254...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-02 15:55 UTC by Nico Sonack
Modified: 2024-06-06 19:21 UTC (History)
1 user (show)

See Also:
nsonack: maintainer-feedback+

Attachments
patch (8.11 KB, patch)
2024-05-02 15:55 UTC, Nico Sonack 		no flags Details | Diff
Patch for open62541 (6.68 KB, patch)
2024-05-04 09:57 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Sonack 2024-05-02 15:55:45 UTC 
Created attachment 250331 [details]
patch

I had to add a few patches. These have already been upstreamed (see commit message).
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 09:57:38 UTC 
Created attachment 250361 [details]
Patch for open62541

Hi,

I made some style changes to the port for better readability and fetched the patch from upstream instead of adding it to the tree if it's ok with you.

Best regards,
Daniel
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 09:58:30 UTC 
I forgot, regarding the LTO stuff...
https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags
Comment 3 Nico Sonack 2024-05-07 14:38:34 UTC 
(In reply to Daniel Engberg from comment #1)

> and fetched the patch from upstream instead of adding it to the tree
I didn't know this was a thing. Thank you! LGTM.

(In reply to Daniel Engberg from comment #2)
> I forgot, regarding the LTO stuff...
> https://docs.freebsd.org/en/books/porters-handbook/book/#dads-cflags
Not sure what you're trying to reference here. Broken link?
Comment 4 Daniel Engberg freebsd_committer freebsd_triage 2024-05-09 05:41:06 UTC 
"The port must respect CFLAGS", it enforces LTO by default
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-06-06 19:08:50 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3b1cab47d54b2cc6e36387044cc19ee4c4d5da7b

commit 3b1cab47d54b2cc6e36387044cc19ee4c4d5da7b
Author:     Nico Sonack <nsonack@outlook.com>
AuthorDate: 2024-06-06 13:04:37 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-06-06 19:05:48 +0000

    devel/open62541: Update to version 1.4.0

    Rename OSSL option to OPENSSL to match the rest of tree

    Changelog: https://github.com/open62541/open62541/releases/tag/v1.4.0

    PR:             278698

 devel/open62541/Makefile  | 26 +++++++++----------
 devel/open62541/distinfo  |  8 +++---
 devel/open62541/pkg-plist | 63 ++++++++---------------------------------------
 3 files changed, 28 insertions(+), 69 deletions(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-06-06 19:21:44 UTC 
Committed, sorry for the wait