Bug 278743 - security/nmap-devel: Convert post-extract to EXTRACT_AFTER_ARGS
Summary: security/nmap-devel: Convert post-extract to EXTRACT_AFTER_ARGS
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-04 18:31 UTC by Daniel Engberg
Modified: 2024-05-06 20:30 UTC (History)
0 users

See Also:
cy: maintainer-feedback+

Attachments
Patch for nmap-devel (782 bytes, patch)
2024-05-04 18:31 UTC, Daniel Engberg 		no flags Details | Diff
Patch for nmap-devel v2 (870 bytes, patch)
2024-05-05 12:42 UTC, Daniel Engberg 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-04 18:31:51 UTC 
Created attachment 250379 [details]
Patch for nmap-devel

Reduces I/O by not extracting at all

Poudirere bulk OK
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2024-05-04 22:31:31 UTC 
Approved.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 12:42:59 UTC 
Created attachment 250442 [details]
Patch for nmap-devel v2

Be more specific about what files to remove and preserve original flags
Comment 3 Daniel Engberg freebsd_committer freebsd_triage 2024-05-05 12:43:31 UTC 
Thanks, I'll commit it later
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-06 20:26:37 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=27e3a3eab4f7f7eece010344ccfaf3f4057cdc6e

commit 27e3a3eab4f7f7eece010344ccfaf3f4057cdc6e
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-05-06 20:11:07 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-05-06 20:11:25 +0000

    security/nmap-devel: Use EXTRACT_AFTER_ARGS

    To decrease I/O load skip extracting files instead of removing after
    extraction

    PR:             278743
    Reviewed by:    cy (maintainer)

 security/nmap-devel/Makefile | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-05-06 20:30:00 UTC 
Committed, thanks!