Bug 278843 - devel/llvm16 - OpenMP Patch - Fix child processes to use affinity_none
Summary: devel/llvm16 - OpenMP Patch - Fix child processes to use affinity_none
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Brooks Davis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-07 22:39 UTC by cbl
Modified: 2024-11-25 23:50 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (brooks)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description cbl 2024-05-07 22:39:49 UTC
New OpenMP patch for llvm16/llvm17/llvm18/llvm-devel to help fix child processes.  do you want a new bug for each of the llvm ports?

https://github.com/llvm/llvm-project/pull/91391

This patch will allow forked children to use all the CPU cores rather than all being locked to the same cpu core.
Comment 1 Brooks Davis freebsd_committer freebsd_triage 2024-05-09 23:45:55 UTC
(In reply to cbl from comment #0)
> do you want a new bug for each of the llvm ports?

A single patch for all would be preferred, but I'll just take care of it (I'm building llvm17 now).  Note that no patch is likely needed for llvm18 or llvm-devel as both will get it in the next update and I have a hard time imagining that waiting a week or two more will make a big difference one way or another.
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-05-10 20:06:22 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=db92b24a9b7176980dff1a05112d9afef2adda97

commit db92b24a9b7176980dff1a05112d9afef2adda97
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2024-05-10 17:20:47 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-05-10 20:04:50 +0000

    devel/llvm16: openmp Fix child processes affinity

    Backport upstream 73bb8d9d92f6:
        [OpenMP] Fix child processes to use affinity_none (#91391)

    PR:             278843
    Submitted by:   cbl@cbl.us

 devel/llvm16/Makefile                              |  2 +-
 .../llvm16/files/patch-backport-73bb8d9d92f6 (new) | 40 ++++++++++++++++++++++
 2 files changed, 41 insertions(+), 1 deletion(-)
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-10 20:06:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=fdb8b5148cc699099d2249c71ab6e83b3f44dba2

commit fdb8b5148cc699099d2249c71ab6e83b3f44dba2
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2024-05-10 17:20:47 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-05-10 20:04:30 +0000

    devel/llvm17: openmp Fix child processes affinity

    Backport upstream 73bb8d9d92f6:
        [OpenMP] Fix child processes to use affinity_none (#91391)

    PR:             278843
    Submitted by:   cbl@cbl.us

 devel/llvm17/Makefile                              |  2 +-
 .../llvm17/files/patch-backport-73bb8d9d92f6 (new) | 40 ++++++++++++++++++++++
 2 files changed, 41 insertions(+), 1 deletion(-)
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-17 18:29:01 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=83f1b7559314d822cae3a9fd90f6996e094b7bc5

commit 83f1b7559314d822cae3a9fd90f6996e094b7bc5
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2024-05-15 23:34:58 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-05-17 18:28:17 +0000

    devel/llvm-devel: new snapshot

    Includes a fix for OpenMP child processes with affinity_none.

    PR:             278843

 devel/llvm-devel/Makefile                               |  2 ++
 devel/llvm-devel/Makefile.snapshot                      |  4 ++--
 devel/llvm-devel/distinfo                               |  6 +++---
 .../files/patch-clang_lib_Headers_CMakeLists.txt        |  4 +++-
 devel/llvm-devel/pkg-plist                              | 17 ++++++++++++++---
 5 files changed, 24 insertions(+), 9 deletions(-)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-05-20 21:31:24 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b74e0482275ebf33f39cc5db20a61d8744d490e1

commit b74e0482275ebf33f39cc5db20a61d8744d490e1
Author:     Brooks Davis <brooks@FreeBSD.org>
AuthorDate: 2024-05-20 20:51:59 +0000
Commit:     Brooks Davis <brooks@FreeBSD.org>
CommitDate: 2024-05-20 21:29:35 +0000

    devel/llvm18: 18.1.6 release

    Included changes are in the release annoucment:
        https://discourse.llvm.org/t/18-1-6-released/79068

    This includes a fix for -march=native which was broken in 18.1.5.  Also
    includs a fix for OpenMP child processes.

    PR:             278843, 279131

 devel/llvm18/Makefile | 2 +-
 devel/llvm18/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)