Bug 278950 - editors/lapce: Fix menu display.
Summary: editors/lapce: Fix menu display.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nuno Teixeira
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-13 11:47 UTC by Mikael Urankar
Modified: 2024-05-14 07:31 UTC (History)
0 users

See Also:
eduardo: maintainer-feedback+

Attachments
v0 (6.55 KB, patch)
2024-05-13 11:47 UTC, Mikael Urankar 		no flags Details | Diff
v0 (1.41 KB, patch)
2024-05-13 13:32 UTC, Mikael Urankar 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikael Urankar freebsd_committer freebsd_triage 2024-05-13 11:47:24 UTC 
Created attachment 250613 [details]
v0

I've created the following pr:
https://github.com/lapce/floem/pull/443
https://github.com/lapce/cosmic-text/pull/6
Comment 1 Mikael Urankar freebsd_committer freebsd_triage 2024-05-13 12:33:29 UTC 
You also need a run_dep on deskutils/xdg-desktop-portal so that "File" -> "Open" button works.
Comment 2 Mikael Urankar freebsd_committer freebsd_triage 2024-05-13 13:11:39 UTC 
It'd be nice to install a .desktop file + icon (there is one in work/lapce-0.4.0-16-g985b07c/extra/linux/dev.lapce.lapce.desktop)
Comment 3 Mikael Urankar freebsd_committer freebsd_triage 2024-05-13 13:32:25 UTC 
Created attachment 250616 [details]
v0

Add desktop file and icon.
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-05-14 07:28:19 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=b9beff373472b8bca33b348314518743a6ef1426

commit b9beff373472b8bca33b348314518743a6ef1426
Author:     Mikael Urankar <mikael@FreeBSD.org>
AuthorDate: 2024-05-14 07:23:19 +0000
Commit:     Nuno Teixeira <eduardo@FreeBSD.org>
CommitDate: 2024-05-14 07:27:35 +0000

    editors/lapce: Fix menu display / Improve port

    - Fix menu display: https://github.com/lapce/floem/pull/443
    - Add desktop file and icon

    PR:             278950

 editors/lapce/Makefile                             |  16 +++-
 editors/lapce/distinfo                             |   2 +-
 ...loem-cosmic-text-0.7.2_src_font_fallback_mod.rs |  21 +++--
 editors/lapce/files/patch-floem (new)              | 100 +++++++++++++++++++++
 4 files changed, 129 insertions(+), 10 deletions(-)
Comment 5 Nuno Teixeira freebsd_committer freebsd_triage 2024-05-14 07:31:48 UTC 
Let's wait for upstream merge floem with freebsd support and remove patch.

Committed, thanks!