Created attachment 250731 [details] git diff against x11-toolkits/itk Add LICENSE for x11-toolkits/itk
More proper LICENSE_PERMS are "dist-mirror dist-sell pkg-mirror pkg-sell auto-accept": with just the auto-accept the distfiles and binary port won't be distributed by FreeBSD: https://docs.freebsd.org/en/books/porters-handbook/book/#licenses-license_perms Chris, your port x11-toolkits/iwidgets has just "auto-accept" in LICENSE_PERMS, while the license for that port says {{{ Permission to use, copy, modify, distribute and license this software and its documentation for any purpose, and without fee or written agreement with DSC, is hereby granted, provided that the above copyright notice appears in all copies and that both the copyright notice and warranty disclaimer below appear in supporting documentation, and that the names of DSC Technologies Corporation or DSC Communications Corporation not be used in advertising or publicity pertaining to the software without specific, written prior permission. }}} And, of course, due to this, iwidgets isn't distributed by FreeBSD (while itk currently is): {{{ # pkg update Updating FreeBSD repository catalogue... FreeBSD repository is up to date. All repositories are up to date. # pkg search iwidgets # pkg search itk ap24-mod_mpm_itk-2.4.7_2 Run each vhost under a separate uid and gid bitkeeper-7.3.3_6 Scalable Distributed Source Management System itk-3.4.2_1 Object-oriented extension to Tk [incr Tk] nuitka-py311-2.5 Compatible and efficient Python compiler simpleitk-2.3.1 Simplification layer built on top of the Insight Toolkit (ITK) }}} Was it intentional? If not, I'd change LICENSE_PERMS for iwidgets to allow it to be "the normal port with package/distfiles distributed by FreeBSD".
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=a3195024cba1f3c2aae636785a41d770c54a3d2e commit a3195024cba1f3c2aae636785a41d770c54a3d2e Author: Chris Hutchinson <portmaster@bsdforge.com> AuthorDate: 2025-01-30 15:22:46 +0000 Commit: Eygene Ryabinkin <rea@FreeBSD.org> CommitDate: 2025-02-10 03:03:23 +0000 x11-toolkits/itk: add LICENSE metadata The license grants rights to (re)distribute the code/binaries, so LICENSE_PERMS were adjusted accordingly (w.r.t. the original patch from PR: it has only "auto-accept" that will make the port and distfile to disappear from FreeBSD packages/CDN). While I am here: separate USES/USE_* section from the rest. PR: 279064 Maintainer timeout: half a year Approved by: yuri@ (mentor) Signed-off-by: Eygene Ryabinkin <rea@FreeBSD.org> x11-toolkits/itk/Makefile | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
License was added to x11-toolkits/itk, thank you! Chris, the question about the license for x11-toolkits/iwidgets (https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279064#c1) still stands, so I'll postpone closing this PR for another week.