Bug 279109 - x11-wm/fvwm2: add LICENSE
Summary: x11-wm/fvwm2: add LICENSE
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Cy Schubert
URL:
Keywords: easy
Depends on:
Blocks:
 
Reported: 2024-05-17 22:02 UTC by Chris Hutchinson
Modified: 2024-06-07 14:30 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)


Attachments
git diff against x11-wm/fvwm2 (703 bytes, patch)
2024-05-17 22:02 UTC, Chris Hutchinson
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hutchinson 2024-05-17 22:02:20 UTC
Created attachment 250774 [details]
git diff against x11-wm/fvwm2

Add (missing) LICENSE for x11-wm/fvwm2
Comment 1 Cy Schubert freebsd_committer freebsd_triage 2024-05-18 00:16:17 UTC
If you can please upload the diff again using git format-patch, I will be able to commit it under your name using your commit.

1. Commit your patch to a branch of your git repo.

2. git format-patch -o /tmp -1

3. Your patch will be in /tmp/0001-some-name.

4. Upload /tmp/0001-some-name to this PR.

I will import your commit into my repo and push it with the email address published in your commit.
Comment 2 Chris Hutchinson 2024-05-18 00:40:58 UTC
(In reply to Cy Schubert from comment #1)
FTR In an effort to improve the condition of
the FreeBSD ports tree. I'm taking on each category
and adding LICENSE for every port missing one.
Today I have completed 2 of those categories;
x11-wm, and x11-toolkits.
I submitted a meta-patch to portmgr@ which wold have
made this effort far more efficient, with a lot less work
for everyone concerned. But that pr (which I don't have
the number of at hand) fell upon deaf ears -- not complaining,
just saying.
In any event. As I don't have a commit bit for the ports
tree. The patch I attached to this pr(1) is a git diff
(as you requested) in a format I'm able to produce w/o that
commit bit. I'm just trying to help. Sorry if you find my
efforts troublesome. :(

--Chris
Comment 3 Chris Hutchinson 2024-05-18 01:33:35 UTC
Here's the bug #278304 I was referring to.
I have already attempted to compose a "proper"
git diff with my name and email address as the
header (in email format). But to no avail, as I
only encountered errors doing so. So I concluded
that unless I become a committer to the ports tree
this method won't work. As I don't have trouble
committing from my local git trees to other git
services.

--Chris
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2024-05-18 01:36:11 UTC
No problem. I'll commit it as is then.
Comment 5 Cy Schubert freebsd_committer freebsd_triage 2024-05-18 01:44:06 UTC
(In reply to Chris Hutchinson from comment #3)

Just add something like this to your ~/.gitconfig:

[user]
        email = cy@FreeBSD.org
        name = Cy Schubert

It can be anything. I had copied my .gitconfig from home to $JOB. My git commits there (at $JOB) were authored by cy@FreeBSD.org until I changed my email in the $JOB .gitconfig to my $JOB email address.

I'll commit this anyway but something to play around with
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-05-18 01:46:51 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bd1e0baebe3d5aa0310ae721a245fb8d61879aff

commit bd1e0baebe3d5aa0310ae721a245fb8d61879aff
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-05-18 01:37:32 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-05-18 01:45:41 +0000

    x11-wm/fvwm2: Add a GPLv2 license

    PR:             279109
    Reported by:    Chris Hutchinson <portmaster@bsdforge.com>
    Submitted by:   Chris Hutchinson <portmaster@bsdforge.com>

 x11-wm/fvwm2/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
Comment 7 Chris Hutchinson 2024-05-18 02:00:52 UTC
(In reply to Cy Schubert from comment #5)
Thanks for the hints, CY. You're awesome. :)