Bug 279128 - devel/kdesvn: Try to prevent overlinking
Summary: devel/kdesvn: Try to prevent overlinking
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-18 13:03 UTC by Daniel Engberg
Modified: 2024-06-10 21:29 UTC (History)
2 users (show)

See Also:
makc: maintainer-feedback+

Attachments
Patch for kdesvn (789 bytes, patch)
2024-05-18 13:03 UTC, Daniel Engberg 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-18 13:03:40 UTC 
Created attachment 250792 [details]
Patch for kdesvn

This appears to fix multiple issues including not longer (incorrectly) depending on BDB5. Please test
Comment 1 Max Brazhnikov freebsd_committer freebsd_triage 2024-05-21 10:33:44 UTC 
(In reply to Daniel Engberg from comment #0)
Daniel,

I doubt anybody is still using kdesvn. If you want this patch to be committed, please test it yourself and commit.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-21 17:59:59 UTC 
Unfortunately, I currently have no way of runtime testing desktop apps.
The other option is to deprecate it.
Comment 3 Tobias C. Berner freebsd_committer freebsd_triage 2024-06-10 17:25:34 UTC 
Moin moin 

I think committing this with a follow-up commit including a deprecation for 2024-12-31 seems reasonable.


mfg Tobias
Comment 4 commit-hook freebsd_committer freebsd_triage 2024-06-10 21:27:53 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1e506684c4f5252aece31fc9d77f825f0443cd4b

commit 1e506684c4f5252aece31fc9d77f825f0443cd4b
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-06-10 21:22:50 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-06-10 21:26:26 +0000

    devel/kdesvn: Deprecate and set expiration date to 2024-12-31

    Due to dwindling amount of users, interest and to streamline
    amount of ports for the KDE Team to maintain

    PR:             279128
    Approved by:    kde (tcberner)

 devel/kdesvn/Makefile | 3 +++
 1 file changed, 3 insertions(+)
Comment 5 commit-hook freebsd_committer freebsd_triage 2024-06-10 21:27:56 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=ba54accf2651fcc45ff208e347e7d3190ecdb08b

commit ba54accf2651fcc45ff208e347e7d3190ecdb08b
Author:     Daniel Engberg <diizzy@FreeBSD.org>
AuthorDate: 2024-06-10 21:06:09 +0000
Commit:     Daniel Engberg <diizzy@FreeBSD.org>
CommitDate: 2024-06-10 21:26:01 +0000

    devel/kdesvn: Try to prevent overlinking

    Add -Wl,--as-needed to LDFLAGS to prevent overlinking and remove
    incorrect dependency of BDB5

    PR:             279128
    Approved by:    kde (tcberner)

 devel/kdesvn/Makefile | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Comment 6 Daniel Engberg freebsd_committer freebsd_triage 2024-06-10 21:29:49 UTC 
Committed, thanks