Bug 279187 - devel/ninja: Update to 1.12.1
Summary: devel/ninja: Update to 1.12.1
Status: Open
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL: https://github.com/ninja-build/ninja/...
Keywords:
Depends on: 279162 279164 279185 279186
Blocks:
  Show dependency treegraph
 
Reported: 2024-05-20 22:41 UTC by Daniel Engberg
Modified: 2024-05-23 07:31 UTC (History)
1 user (show)

See Also:
jhale: maintainer-feedback+


Attachments
Patch for ninja (2.75 KB, patch)
2024-05-20 22:41 UTC, Daniel Engberg
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Engberg freebsd_committer freebsd_triage 2024-05-20 22:41:04 UTC
Created attachment 250842 [details]
Patch for ninja

Switch to CMake as it's much more commonly used, speeds up building and cleans up Makefile
Comment 1 Jason E. Hale freebsd_committer freebsd_triage 2024-05-23 04:01:48 UTC
Ninja 1.12.x continues to be problematic with qt[5|6]-webengine with an unsolved race condition.
Comment 2 Daniel Engberg freebsd_committer freebsd_triage 2024-05-23 04:57:32 UTC
How are these confirmed and they using stock config? I do see failures in general using a VM with very sluggish I/O during heavy load which might be what you're looking at but it has been an issue for years.

Having that in mind,

Both build boxes I have compiles fine with ninja 1.12.1.

Ports:
www/qt5-webengine
www/qt6-webengine

"Fast" (Ryzen 7900, 128Gb RAM)
Host: 14.0-RELEASE-p6
Jail: 14.0-RELEASE
PARALLEL_JOBS=8
MAX_FILES_qt5_webengine=4096
MAX_FILES_qt6_webengine=4096
MAKE_JOBS_NUMBER_LIMIT=8

"Slow" (Xeon CPU E5-2683 v4, 128Gb RAM)
Host: 14.0-RELEASE-p3
Jail: 14.0-RELEASE-p4
PARALLEL_JOBS=8
MAX_FILES_qt5_webengine=4096
MAX_FILES_qt6_webengine=4096
MAKE_JOBS_NUMBER_LIMIT=8

Best regards,
Daniel
Comment 3 Jason E. Hale freebsd_committer freebsd_triage 2024-05-23 07:31:37 UTC
I thought these were good to go too after the exp-run (bug #278693), but after rebuilding with ccache enabled, I have been able to reproduce and confirm the exact failures in bug #279162 and bug #279164 myself. Yes, they were using the standard options as was I. Not going to disbelieve the reports of 3 reputable individuals plus my own observations.

Believe me, I am thoroughly frustrated and extremely disappointed after spending countless hours fixing build errors in our 9 chromium-based ports, especially with iridium. OOM errors for qt*-webengine in the official package builders, especially for i386 are irrelevant.

Like I said, I had successful initial builds with ninja 1.12.x, but rebuilds with ccache enabled have lead to failure and sadness. I rolled back ninja from 1.12.1 to 1.12.0 initially thinking there may have been a problem with it after the exp-run for ninja 1.12.0 came back successful, but clearly there are more problems to be addressed with even ninja 1.12.0.

I have a glorious seven year old core i7 laptop with 32GB of RAM, and even it doesn’t like ninja 1.12.x + qt*-webengine. I’d greatly appreciate help since I’m obviously limited on resources, but the problem is real.