Bug 279217 - ftp/freebsd-ftpd ls output missing file-owner field in 14.0
Summary: ftp/freebsd-ftpd ls output missing file-owner field in 14.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Cy Schubert
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-22 11:44 UTC by Stewart Morgan
Modified: 2024-05-23 03:13 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (cy)

Attachments
Removes '-g' from /bin/ls arguments (872 bytes, patch)
2024-05-22 11:44 UTC, Stewart Morgan 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stewart Morgan 2024-05-22 11:44:43 UTC 
Created attachment 250871 [details]
Removes '-g' from /bin/ls arguments

In FreeBSD 14, the "-g" flag to /bin/ls changed from "backwards compatible, do nothing" to "remove the file-owner column from the output".  This breaks compatibility with FTP clients expecting to see that field.
Since "-g" previously did nothing, the attached patch simply removes it from the locations (in ftpd.c and ftpcmd.y) that I could see it being used.
Stewart
Comment 1 Stewart Morgan 2024-05-22 12:42:23 UTC 
Looks like @allenjude beat me to the punch with this source commit 13hours ago :)
https://github.com/freebsd/freebsd-src/commit/e20971500194d2f7299e9d01ca3b20e9bc6b4009
Comment 2 Cy Schubert freebsd_committer freebsd_triage 2024-05-22 15:05:18 UTC 
I'll need to pull this into the upstream git repo.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-05-23 03:11:34 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=1f583d8e7410f84eeefc55388cbb6940432e5104

commit 1f583d8e7410f84eeefc55388cbb6940432e5104
Author:     Cy Schubert <cy@FreeBSD.org>
AuthorDate: 2024-05-23 03:08:37 +0000
Commit:     Cy Schubert <cy@FreeBSD.org>
CommitDate: 2024-05-23 03:11:18 +0000

    ftp/freebsd-ftpd: Pull in latest upstream commit

    The latest upstream commit includes ftpd commits gleaned from
    freebsd/main as of 2024-05-21.

    PR:     279217
    MFH:    2024Q2

 ftp/freebsd-ftpd/Makefile | 3 ++-
 ftp/freebsd-ftpd/distinfo | 6 +++---
 2 files changed, 5 insertions(+), 4 deletions(-)
Comment 4 Cy Schubert freebsd_committer freebsd_triage 2024-05-23 03:12:50 UTC 
I have updated upstream -- I own the upstream git repo -- and have updated the port to point to the latest hash. This will be tagged when 15-CURRENT goes GA.