Created attachment 250905 [details] add IGNORE_WITH_MYSQL with all MariaDB versions in ports databases/p5-DBD-mysql doesn't support MariaDB - add IGNORE_WITH_MYSQL with all MariaDB versions in ports.
Is it possible to add extra message in IGNORE_WITH_MYSQL "use databases/p5-DBD-mysql4 or databases/p5-DBD-MariaDB instead"? Or better to use this: > .if ${MYSQL_FLAVOUR} == mariadb > IGNORE=use databases/p5-DBD-mysql4 or databases/p5-DBD-MariaDB instead > .endif instead of this: > IGNORE_WITH_MYSQL= 105m 106m 1011m ?
I've been CC'ed on bug #277922 where this was implemented. I have to upgrade the port to 5.005 too. I'll pick this up after work today and kill two birds with one stone.
Created attachment 251020 [details] Update to 5.005 and add IGNORE Used .if ${MYSQL_FLAVOUR} != mysql IGNORE=use databases/p5-DBD-mysql4 or databases/p5-DBD-MariaDB instead .endif There used to be a percona version too, or some other compatible database may get added again in the future. And I presume the code doesn't work with any of those too. Port gets IGNOREd with mysql=10.11m (or any other mariadb version). [00:00:14] Ignoring databases/p5-DBD-mysql | p5-DBD-mysql-5.005: use databases/p5-DBD-mysql4 or databases/p5-DBD-MariaDB instead Updated port to 5.005 too. Changelog: https://github.com/perl5-dbi/DBD-mysql/releases/tag/5_005
(In reply to Remko Catersels from comment #3) Did you tested build in poudriere? Last time I tested got: "make stage-qa" in poudriere (13.3-p2 amd64, mysql 8.0 and 8.1) print error: Warning: you need USES=ssl Error: /usr/local/lib/perl5/site_perl/mach/5.36/auto/DBD/mysql/mysql.so is linked to /usr/local/lib/libunwind.so.8 from devel/libunwind but it is not declared as a dependency Warning: you need LIB_DEPENDS+=libunwind.so:devel/libunwind
(In reply to Vladimir Druzenko from comment #4) Did a testport yes, don't think I noticed any issues but I'll recheck.
Created attachment 251028 [details] Update to 5.005, add IGNORE and missing dependencies Right, that was easy to overlook in a wall of text. It also complained about libunwind, added that too. Also tried to fix p5-Module-CoreList but that turned a notice into a warning. Not sure if I did it properly or if it's actually needed right now, so I left it as is. ====> Running Q/A tests (stage-qa) Warning: you might not need LIB_DEPENDS on libmysqlclient.so.21 Notice: You have some Perl modules as dependencies but you do not have devel/p5-Module-CoreList installed, the perlcore QA check get s better results when using it, especially with older Perl versions. ====> Checking for pkg-plist issues (check-plist) ===> Parsing plist ===> Checking for items in STAGEDIR missing from pkg-plist ===> Checking for items in pkg-plist which are not in STAGEDIR ===> No pkg-plist issues found (check-plist) =>> Checking for staging violations... done
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=31b1edc0d2c4b13db76a583d512f34af68273681 commit 31b1edc0d2c4b13db76a583d512f34af68273681 Author: Remko Catersels <sirdice@gmail.com> AuthorDate: 2024-05-27 21:06:40 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-05-27 21:25:10 +0000 databases/p5-DBD-mysql: update to 5.005, fix build in poudriere, add IGNORE for non-mysql Changelog: https://github.com/perl5-dbi/DBD-mysql/releases/tag/5_005 Since 5.x upstream doesn't support MariaDB - add IGNORE for non-mysql. PR: 279256 277889 MFH: 2024Q2 databases/p5-DBD-mysql/Makefile | 13 ++++++++++--- databases/p5-DBD-mysql/distinfo | 6 +++--- 2 files changed, 13 insertions(+), 6 deletions(-)
A commit in branch 2024Q2 references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=078ec064a0d31397fcefdb5d6aec1ddb7a5f6b0d commit 078ec064a0d31397fcefdb5d6aec1ddb7a5f6b0d Author: Remko Catersels <sirdice@gmail.com> AuthorDate: 2024-05-27 21:06:40 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-05-27 21:29:05 +0000 databases/p5-DBD-mysql: update to 5.005, fix build in poudriere, add IGNORE for non-mysql Changelog: https://github.com/perl5-dbi/DBD-mysql/releases/tag/5_005 Since 5.x upstream doesn't support MariaDB - add IGNORE for non-mysql. PR: 279256 277889 MFH: 2024Q2 (cherry picked from commit 31b1edc0d2c4b13db76a583d512f34af68273681) databases/p5-DBD-mysql/Makefile | 13 ++++++++++--- databases/p5-DBD-mysql/distinfo | 6 +++--- 2 files changed, 13 insertions(+), 6 deletions(-)
Thanks.