Bug 279275 - x11/babl: sort out Makefile and pet portclippy
Summary: x11/babl: sort out Makefile and pet portclippy
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-24 18:29 UTC by Vladimir Druzenko
Modified: 2024-06-01 23:25 UTC (History)
4 users (show)

See Also:
fluffy: maintainer-feedback+


Attachments
sort out Makefile and pet portclippy v1 (2.24 KB, patch)
2024-05-24 18:29 UTC, Vladimir Druzenko
no flags Details | Diff
sort out Makefile and pet portclippy v2 (1.83 KB, patch)
2024-05-24 21:59 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-24 18:29:31 UTC
Created attachment 250927 [details]
sort out Makefile and pet portclippy v1

Suggested by diizzy https://reviews.freebsd.org/D45094#1028356: 
> x11/babl likely doesn't require libtool, you can probably drop localbase or or at least use localbase:ldflags
Both removed.
> SIMD option is only relevant on i386/amd64 (fix) and we can at least always rely on SSE2 on amd64 (requirement).
Limit SIMD to i386/amd64, default for i386 is MMX only, for amd64 SSE2. But users can turn on or off all SIMD sets during build. 
> It would be nice(r) if we could rely on CPUTYPE from the framework

Tested build in poudriere and on live system 13.3-p2 amd64 and i386 with different combinations of SIMDs and CPUTYPE in /etc/make.conf.
Comment 1 Robert Clausecker freebsd_committer freebsd_triage 2024-05-24 21:54:39 UTC
plist issues on arm64:

Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-CIE.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-cairo.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-double.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-float.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gegl-fixups.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gggl-lies.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-gggl.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-grey.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-simple.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-u16.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-u32.so
Error: Missing: lib/babl-%%BABL_VER%%/arm-neon-ycbcr.so

Test suite passes except for:

 9/28 float-to-8bit                           FAIL            0.34s

stdout:
 float -> u8 1 failed #1[1]  got 76 expected 77
stderr:
        " 0x2dbc9de6f8b0 0x2dbc9de6d930 1"      70925056        BablFishPath
                cost:637.000000 error:0.000000000000
        "/wrkdirs/usr/ports/x11/babl/work/babl-0.1.108/_build/extensions/gggl.so 0: R'G'B'A float to R'G'B'A u8"      0BablConversionLinear
                pixels:0
                error: 0.000000
Comment 2 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-24 21:59:56 UTC
Created attachment 250932 [details]
sort out Makefile and pet portclippy v2

1. Fixed plist for aarch64.
2. Removed MMX from default options for i386: base line is Pentium Pro - it doesn't have MMX.
Comment 3 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-24 22:02:56 UTC
(In reply to Robert Clausecker from comment #1)
>  9/28 float-to-8bit                           FAIL            0.34s
> stdout:
> float -> u8 1 failed #1[1]  got 76 expected 77
It's known issue: https://gitlab.gnome.org/GNOME/babl/-/issues/88
Comment 4 Robert Clausecker freebsd_committer freebsd_triage 2024-05-24 22:17:50 UTC
The updated patch tests fine on armv7.
No more plist issues on arm64, though the test suite failure persists.
Comment 5 Vladimir Druzenko freebsd_committer freebsd_triage 2024-05-31 11:27:05 UTC
Waiting one more week for "maintainer timeout 2 weeks"…
Comment 6 Dima Panov freebsd_committer freebsd_triage 2024-06-01 20:05:43 UTC
LGTM
Comment 7 Daniel Engberg freebsd_committer freebsd_triage 2024-06-01 20:23:13 UTC
We should sort out aarch64 failure?
Comment 8 Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-01 20:26:16 UTC
(In reply to Daniel Engberg from comment #7)
It fixed in v2.
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-06-01 23:24:44 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bb1c7512f9d178ff5711bb2051006916482aa47a

commit bb1c7512f9d178ff5711bb2051006916482aa47a
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-01 20:20:01 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-01 23:16:56 +0000

    x11/babl: sort out Makefile and pet portclippy

    Remove localbase.
    Limit SIMD to i386/amd64, default for i386 is none, for amd64 SSE2.
    But users can turn on or off all SIMD sets during build.

    PR:             279275
    Approved by:    fluffy (gnome, maintainer)

 x11/babl/Makefile | 45 +++++++++++++++++++++++++++++++++++----------
 1 file changed, 35 insertions(+), 10 deletions(-)