Created attachment 251081 [details] patch-transmission_4.0.6
Looks like rapidjson dependency line should be moved 1 pos above.
Committed, Thanks!
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=8326d697863137f1665bd21a1fc148b6363540fb commit 8326d697863137f1665bd21a1fc148b6363540fb Author: Fernando Apesteguía <fernape@FreeBSD.org> AuthorDate: 2024-05-31 18:00:59 +0000 Commit: Fernando Apesteguía <fernape@FreeBSD.org> CommitDate: 2024-06-01 11:57:23 +0000 net-p2p/transmission*: update to 4.0.6 ChangeLog: https://github.com/transmission/transmission/releases/tag/4.0.6 All Platforms Improved parsing HTTP tracker announce response. * Fixed 4.0.0 bug that caused some user scripts to have an invalid TR_TORRENT_TRACKERS environment variable. * Fixed 4.0.0 bug where alt-speed-enabled had no effect in settings.json. * Fixed 4.0.0 bug where the GTK client's "Use authentication" option was not saved between's sessions. * Fixed 4.0.0 bug where the filename for single-file torrents aren't sanitized. macOS Client * Fix: Sparkle support for handling beta version updates. * Fixed app unable to start when having many torrents and TimeMachine enabled. * Fix: Sparkle Version Comparator. Qt Client * Fixed 4.0.0 bug where piece size description text and slider state in torrent creation dialog are not always up-to-date. GTK Client * Fixed build when compiling with GTKMM 4. * Added developer name to metainfo files. * Added the launchable desktop-id to metainfo files. * Fixed build when compiling on BSD. Web Client * Fixed a 4.0.0 bug where the infinite ratio symbol was displayed incorrectly in the WebUI. * Fixed layout issue in speed display. * General UI improvement related to filterbar and fixes download/upload speed info wrap. Daemon * Fixed a couple of logging issues. Everything Else * Updated flatpak release metainfo. * Fixed libtransmission build on very old cmake versions. * UTP peer connections follow user-defined speed limits better now. * Only use a single concurrent queue for timeMachineExclude instead of one queue per torrent * Fixed 4.0.5 bug where svg and png icons in the WebUI might not be displayed. * Fixed 4.0.0 bug where alt-speed-enabled had no effect in settings.json. * Fixed 4.0.0 bugs where some RPC methods don't put torrents in recently-active anymore. * Improved parsing HTTP tracker announce response. * Fixed compatibility with clang-format 18. * Fixed build when compiling with mbedtls 3.x . PR: 279396 Reported by: mondo.debater_0q@icloud.com (maintainer) net-p2p/transmission-components/Makefile | 9 +++++---- net-p2p/transmission-components/distinfo | 6 +++--- .../files/patch-cmake_FindFastFloat.cmake | 6 +++--- .../transmission-components/files/patch-cmake_FindFmt.cmake | 4 ++-- .../files/patch-cmake_FindUtfCpp.cmake | 6 +++--- .../files/patch-gtk_Application.cc (gone) | 11 ----------- .../files/patch-gtk_DetailsDialog.cc (gone) | 10 ---------- .../files/patch-libtransmission_file-posix.cc (gone) | 11 ----------- .../files/patch-libtransmission_variant-json.cc (gone) | 11 ----------- net-p2p/transmission/Makefile | 4 ++-- 10 files changed, 18 insertions(+), 60 deletions(-)
(In reply to Fernando Apesteguía from comment #2) Fernando, did you have a look at comment #1? AFAIK dependency lines should be in ascending alphabetical order...
(In reply to Anton Saietskii from comment #4) Sorry I missed that Anton, The port in general could use a bit of help from portlint and portclipply :-) I'll try to make some changes if I have time. Thanks!
Created attachment 251327 [details] patch-transmission_4.0.6_1 Apologies for resurrecting an old thread, but I don't think cleaning this up merits a new bug request. The port tools do not handle flavors well in my experience. I have attached the diff that will serve as the basis for the next bump, which has a bit cleanup. If there are other specific things you think should be done, please let me know.
(In reply to Rafe from comment #6) Thank you very much for the improvements Rafe, your work is very much appreciated.
(In reply to Fernando Apesteguía from comment #8) I'd like to note that PORTREVISION has been bumped incorrectly since resulting packages didn't change.
(In reply to Anton Saietskii from comment #9) Thanks for the heads up. I think we are safe though. The last commit had cosmetic changes in the Makefile and didn't really change the package or impacted users. I don't think a new bump is required. It can be postponed until the next major version is updated.
(In reply to Fernando Apesteguía from comment #10) Fernando, I didn't say new bump required, I'm saying the opposite — previous was NOT required. :-) We shouldn't bump unless package (or maintainer changes). [0] [0]: https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-portrevision
(In reply to Anton Saietskii from comment #11) Ahhhh, ok, hehe. I misunderstood.