Bug 279409 - devel/meson: update to 1.4.1
Summary: devel/meson: update to 1.4.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-desktop (Team)
URL: https://github.com/mesonbuild/meson/c...
Keywords:
Depends on:
Blocks:
 
Reported: 2024-05-30 20:08 UTC by Jan Beich
Modified: 2024-06-02 22:09 UTC (History)
2 users (show)

See Also:
antoine: exp-run+


Attachments
v1 (apply via "git am") (1.24 KB, patch)
2024-05-30 20:08 UTC, Jan Beich
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2024-05-30 20:08:31 UTC
Created attachment 251101 [details]
v1 (apply via "git am")
Comment 1 Marcin Cieślak 2024-06-02 14:59:57 UTC
With meson 1.4.0 I am getting the following warnings:


WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug. Using both is redundant since they override each other. See: https://mesonbuild.com/Builtin-options.html#build-type-options

WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.


Shall we update Uses/meson.mk to reflect this? (or shall I open another PR?)
Comment 2 Jan Beich freebsd_committer freebsd_triage 2024-06-02 18:43:53 UTC
Please, open separate bugs for issues not related to this update. I'm definitaley not going to fix these on the same bandwagon. Scope creep is a recipe for bugs.

> WARNING: Recommend using either -Dbuildtype or -Doptimization + -Ddebug.

Likely regressed by bug 272321. Beware, -Dbuildtype=release enables -Db_ndebug=if-release and allows consumers to check "buildtype" to enable extra steps.

> WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]`

Patches welcome. USES=meson currently uses CONFIGURE_CMD instead of custom do-configure and DO_MAKE_BUILD via USES=ninja instead of "meson compile".
Comment 3 Jan Beich freebsd_committer freebsd_triage 2024-06-02 18:50:17 UTC
(In reply to Jan Beich from comment #2)
> Scope creep is a recipe for bugs.

... or burnout. I'm mainly update devel/meson to help FreeBSD CI in some upstream projects like wlroots. If you want to dump more work on me I can easily excuse myself to focus on my own ~280 ports. There's a reason this port is under desktop@ instead of jbeich@ or another individual committer.
Comment 4 Marcin Cieślak 2024-06-02 19:11:38 UTC
(In reply to Jan Beich from comment #3)

Thank you, I was working on something else and I should have taken this to the mailing list instead. Sorry.
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2024-06-02 21:28:27 UTC
Exp-run looks fine
Comment 6 commit-hook freebsd_committer freebsd_triage 2024-06-02 22:09:20 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=bfe721a69c5e23499143257a2d0af4a992076c02

commit bfe721a69c5e23499143257a2d0af4a992076c02
Author:     Jan Beich <jbeich@FreeBSD.org>
AuthorDate: 2024-05-30 16:11:29 +0000
Commit:     Jan Beich <jbeich@FreeBSD.org>
CommitDate: 2024-06-02 22:07:50 +0000

    devel/meson: update to 1.4.1

    Changes:        https://github.com/mesonbuild/meson/compare/1.4.0...1.4.1
    PR:             279409
    Reported by:    GitHub (watch releases)
    Exp-run by:     antoine

 devel/meson/Makefile | 2 +-
 devel/meson/distinfo | 6 +++---
 2 files changed, 4 insertions(+), 4 deletions(-)