Bug 279457 - graphics/openshadinglanguage: sort out Makefile, pet portclippy, add graphics/partio as dependency
Summary: graphics/openshadinglanguage: sort out Makefile, pet portclippy, add graphics...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Vladimir Druzenko
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-01 23:22 UTC by Vladimir Druzenko
Modified: 2024-06-09 16:22 UTC (History)
2 users (show)

See Also:


Attachments
v1 (3.51 KB, patch)
2024-06-01 23:22 UTC, Vladimir Druzenko
vvd: maintainer-approval?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vladimir Druzenko freebsd_committer freebsd_triage 2024-06-01 23:22:54 UTC
Created attachment 251144 [details]
v1

Tested build in poudriere (testport) and on live system 13.3 amd64.

Grab silently graphics/partio (small library for reading, writing, and manipulating
a variety of standard particle formats GEO, BGEO, PTC, PDB, PDA) if installed, but didn't find possibility to turn this off without patching sources - add it as mandatory dependency.

And a lot of other small changes - I can explain each.
Comment 1 Shane 2024-06-02 03:38:49 UTC
Comment on attachment 251144 [details]
v1

looks OK to me
Comment 2 commit-hook freebsd_committer freebsd_triage 2024-06-09 16:21:52 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=7cb9bbeced6ca9890d332f55ac5827cc932b8248

commit 7cb9bbeced6ca9890d332f55ac5827cc932b8248
Author:     Vladimir Druzenko <vvd@FreeBSD.org>
AuthorDate: 2024-06-09 16:03:55 +0000
Commit:     Vladimir Druzenko <vvd@FreeBSD.org>
CommitDate: 2024-06-09 16:21:06 +0000

    graphics/{,py-}openshadinglanguage: sort out Makefile, pet portclippy, add graphics/partio as dependency

    Grab silently graphics/partio (small library for reading, writing, and
    manipulating a variety of standard particle formats GEO, BGEO, PTC, PDB, PDA)
    if installed.
    It's possible to create build option PARTIO and prevent search partio with
    PARTIO_CMAKE_OFF=-DCMAKE_DISABLE_FIND_PACKAGE_partio:BOOL=ON, but partio is
    small and is on by default by ustream - so add it as mandatory dependency.

    Also rename renamed by upstream ENABLERTTI to ENABLE_RTTI and pet portclippy.

    PR:             279457
    Approved by:    Shane <FreeBSD@ShaneWare.Biz> (maintaner)

 graphics/openshadinglanguage/Makefile    | 29 +++++++++++++++--------------
 graphics/py-openshadinglanguage/Makefile |  2 +-
 2 files changed, 16 insertions(+), 15 deletions(-)