Created attachment 251293 [details] v1 Upstream prefer to use archivers/zlib-ng instead of old zlib - add it in LIB_DEPENDS. While here pet portclippy. Tested build in poudriere 13.3 amd64, i386 and on live system 13.3, 14.1 amd64. Also test build consumer graphics/opencolorio in poudriere 13.3 amd64.
Please keep the current layout in Makefile as it much better than what portclippy suggests and it isn't always "right". Does zlib-ng pick the correct library by itself?
(In reply to Daniel Engberg from comment #1) 1. Can you show full list of the variables in port's Makefile with correct order? Didn't find this in the FreeBSD Porter's Handbook. On the other side porclippy and portlint was recommended by my former mentors. 2. If I understood the question correctly, then: https://github.com/zlib-ng/minizip-ng/blob/4.0.6/CMakeLists.txt#L173 Search for both ZLIBNG and ZLIB, if find ZLIBNG, then pick it and ignore ZLIB.
1. I don't have a complete list, just look at some well established ports and you'll get the idea 2. Pass CMAKE_ON= CMAKE_DISABLE_FIND_PACKAGE_ZLIB to make sure
Created attachment 251319 [details] v2 (In reply to Daniel Engberg from comment #3) 1. I read Makefiles from hundreds ports - everywhere is different. If there is a complete list in the correct order, then this would close all such questions. But while it’s not there, I’m using the method recommended by my mentors. 2. Thanks, added (tested).
A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=7473cd3f759b96609a8448ef1969296bad5f467b commit 7473cd3f759b96609a8448ef1969296bad5f467b Author: Vladimir Druzenko <vvd@FreeBSD.org> AuthorDate: 2024-06-10 20:21:10 +0000 Commit: Vladimir Druzenko <vvd@FreeBSD.org> CommitDate: 2024-06-10 20:21:10 +0000 archivers/minizip-ng: udpate to 4.0.6 Changelog: https://github.com/zlib-ng/minizip-ng/releases/tag/4.0.6 Upstream prefer to use archivers/zlib-ng instead of old zlib - add it in LIB_DEPENDS and prevent search old zlib. While here pet portclippy. PR: 279593 Approved by: lbartoletti (maintainer, via IRC) archivers/minizip-ng/Makefile | 9 +++++---- archivers/minizip-ng/distinfo | 6 +++--- archivers/minizip-ng/pkg-plist | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-)