Bug 279816 - Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set
Summary: Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set
Status: New
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Port Management Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-17 14:14 UTC by Brad Davis
Modified: 2024-06-17 14:14 UTC (History)
1 user (show)

See Also:

Attachments
patch (654 bytes, patch)
2024-06-17 14:14 UTC, Brad Davis 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brad Davis freebsd_committer freebsd_triage 2024-06-17 14:14:59 UTC 
Created attachment 251525 [details]
patch

When debugging some fetch failures I noticed that my port was always trying to fetch from github instead of gitlab when USE_GITLAB and USE_GITHUB=nodefault is set.  This appears to be because we check that MASTER_SITES is empty before USE_GITLAB has a chance to be run.

The attached patch modifies the logic so that USE_GITHUB=nodefault is checked even if MASTER_SITES is empty so that USE_GITLAB can populate it later.