Bug 279831 - lang/dotnet: Update to 8.0.6
Summary: lang/dotnet: Update to 8.0.6
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Gleb Popov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-06-18 13:51 UTC by Naram Qashat
Modified: 2024-06-22 19:25 UTC (History)
0 users

See Also:
arrowd: maintainer-feedback+


Attachments
dotnet-8.0.6.patch (34.66 KB, patch)
2024-06-18 13:51 UTC, Naram Qashat
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Naram Qashat 2024-06-18 13:51:34 UTC
Created attachment 251536 [details]
dotnet-8.0.6.patch

- Update to 8.0.6
  * Also update SDKVERSION to 8.0.106
- Fix a few things in the Makefile that portlint noticed
  * ONLY_FOR_ARCHS and BINARY_ALIAS use a tab instead of spaces after the equal sign
  * Can't do anything about the BROKEN statement for 15.x having quotes in it
  * Leaving COMMENT alone despite portlint saying it is too long
  * Moved DIST_SUBDIR to earlier in the file
  * It says BROKEN needs to appear earlier but I did not know where to put it so I left them where they were
  * It complained about the LIB_DEPENDS for 14.x+ having an ABI number on it, not sure how to fix that since it seems to only be necessary if using base OpenSSL instead of ports.
  * Did not touch any patches so it complains about 2 of them.
- Update distinfo
- Update pkg-plist
  * Some things that used variables were hardcoded because it appears they always use certain values regardless (even in the official releases)

Tested in poudriere for 13 amd64. Did not test aarch64 due to time and my system being occupied. Could not test 14 as I don't have a poudriere setup for that yet.
Comment 1 Gleb Popov freebsd_committer freebsd_triage 2024-06-18 14:06:41 UTC
It seems strange that SDKVERSION in the pkg-plist is still .100
It probably means that something's missing here?
Comment 2 Naram Qashat 2024-06-18 14:13:51 UTC
(In reply to Gleb Popov from comment #1)
If you are talking about that first change for metadata and all the ones in sdk-manifests, it is like that even an the official Linux dotnet install.

From a Ubuntu jail with .NET 8.0.6 installed:

root@kirby:/# ls /usr/share/dotnet/sdk-manifests/
8.0.100

What was even weirder to me, though, was the FSharp.Core nupkg having an entirely different SDK version number on it. Even in the Ubuntu jail, it has an SDK version of 8.0.300 despite the installed SDK being 8.0.301. The directory structure is kinda bonkers in some regards.
Comment 3 commit-hook freebsd_committer freebsd_triage 2024-06-22 19:25:03 UTC
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=3e0551d698cee8b890b8c4d728b73c27c7258144

commit 3e0551d698cee8b890b8c4d728b73c27c7258144
Author:     Naram Qashat <cyberbotx@cyberbotx.com>
AuthorDate: 2024-06-22 19:21:49 +0000
Commit:     Gleb Popov <arrowd@FreeBSD.org>
CommitDate: 2024-06-22 19:24:38 +0000

    lang/dotnet: Update to 8.0.6

    PR:             279831

 lang/dotnet/Makefile  |   20 +-
 lang/dotnet/distinfo  |   10 +-
 lang/dotnet/pkg-plist | 2591 +++++++++++++++++++++++++------------------------
 3 files changed, 1311 insertions(+), 1310 deletions(-)
Comment 4 Gleb Popov freebsd_committer freebsd_triage 2024-06-22 19:25:35 UTC
Pushed with some adjustments, thank you!