Bug 279907 - devel/sdl20: Joystick not working with latest SDL
Summary: devel/sdl20: Joystick not working with latest SDL
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Dmitry Marakasov
URL:
Keywords: patch-ready
Depends on:
Blocks:
 
Reported: 2024-06-22 13:04 UTC by Ganael LAPLANCHE
Modified: 2024-07-25 14:05 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (amdmi3)

Attachments
Joystick handling fix for SDL 2.0 (1.24 KB, text/plain)
2024-06-22 13:04 UTC, Ganael LAPLANCHE 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-06-22 13:04:16 UTC 
Created attachment 251619 [details]
Joystick handling fix for SDL 2.0

Hello Dmitry,

devel/sdl20 recently switched to using CMake. Since that update (commit c14f535a), my XBox One controller is not working anymore with certain apps.

Previous update (c807eaa9) recognizes it and makes it work perfectly.

Digging into that, I found that file src/joystick/linux/SDL_sysjoystick.c (the one handling input from /dev/input/xxx devices) is not compiled anymore with latest update (while it was in previous version).

The attached patch fixes the situation and makes the joystick work again.

Cheers,

Ganael.
Comment 1 Daniel Engberg freebsd_committer freebsd_triage 2024-06-22 13:34:19 UTC 
Hi,

Can you please submit it upstream?

Best regards,
Daniel
Comment 2 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-06-22 14:02:39 UTC 
Hello Daniel,

I have reported the bug here: https://github.com/libsdl-org/SDL/pull/10087

Cheers,

Ganael.
Comment 3 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-06-22 15:22:10 UTC 
The change has been merged upstream. I presume I can close that PR for now, as the fix will come with next port update.

Cheers,

Ganael.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2024-07-24 19:08:22 UTC 
Please never close my PRs.
I could've backported the fix to the earlier version, but this PR was lost.
Comment 5 Daniel Engberg freebsd_committer freebsd_triage 2024-07-24 19:13:50 UTC 
(In reply to Ganael LAPLANCHE from comment #2)
Sorry for the late reply, thanks for fixing it upstream! :)
Comment 6 Ganael LAPLANCHE freebsd_committer freebsd_triage 2024-07-25 14:05:54 UTC 
(In reply to Dmitry Marakasov from comment #4)

Hello Dmitry,

Sorry, I may have acted a bit too fast.

You're right, it's better to leave PRs opened for maintainers to review them. I'll be more careful next time !

Cheers,

Ganael