Bug 279993 - games/gnushogi: Fix games/xshogi not working and take maintainership
Summary: games/gnushogi: Fix games/xshogi not working and take maintainership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Zsolt Udvari
URL:
Keywords:
Depends on:
Blocks: 280023
  Show dependency tree / graph
 
Reported: 2024-06-26 01:22 UTC by mew14930xvi
Modified: 2024-10-28 04:39 UTC (History)
1 user (show)

See Also:

Attachments
fix xshogi not working (3.43 KB, patch)
2024-06-26 01:22 UTC, mew14930xvi 		no flags Details | Diff
fix xshogi not working (3.78 KB, patch)
2024-06-26 02:12 UTC, mew14930xvi 		no flags Details | Diff
fix xshogi not working (3.77 KB, patch)
2024-06-26 20:46 UTC, mew14930xvi 		no flags Details | Diff
fix xshogi not working (3.79 KB, patch)
2024-07-02 19:32 UTC, mew14930xvi 		no flags Details | Diff
fix xshogi not working (5.86 KB, patch)
2024-10-04 13:18 UTC, mew14930xvi 		no flags Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mew14930xvi 2024-06-26 01:22:08 UTC 
Created attachment 251700 [details]
fix xshogi not working

update WWW
use PLIST_FILES
Comment 1 mew14930xvi 2024-06-26 02:12:30 UTC 
Created attachment 251701 [details]
fix xshogi not working

edit pkg-descr
Comment 2 mew14930xvi 2024-06-26 20:46:03 UTC 
Created attachment 251711 [details]
fix xshogi not working

remove INFO option
Comment 3 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-01 05:20:59 UTC 
Could you please test without MAKE_JOBS_UNSAFE? For me it works.
And please check "portfmt -D Makefile".

Thanks.
Comment 4 mew14930xvi 2024-07-02 19:32:03 UTC 
Created attachment 251839 [details]
fix xshogi not working

MAKE_JOBS_UNSAFE excluded.
Slightly rearranged.
I don't like "portfmt -D Makefile" with more lines because my screen is not wide enough.
Comment 5 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-03 12:18:11 UTC 
I can't run xshogi with your gnushogi-modification:

$ xshogi                                                                                                                                                X Error of failed request:  BadName (named color or font does not exist)
  Major opcode of failed request:  45 (X_OpenFont)
  Serial number of failed request:  20
  Current serial number in output stream:  21

The xshogi is from FreeBSD repository (not yours). What's wrong?
Comment 6 mew14930xvi 2024-07-03 14:13:50 UTC 
Requires xorg-fonts-100dpi or xorg-fonts-75dpi or xorg-fonts-cyrillic.
Installed with x11/xorg dependencies but not with x11/xorg-minimal.
Comment 7 Zsolt Udvari freebsd_committer freebsd_triage 2024-07-03 16:53:58 UTC 
(In reply to mew14930xvi from comment #6)
Ah, okay. But in this case these fonts should be dependency. Please add them!
I'll test it tomorrow.

(I installed only the necessary packages of xorg, not xorg or xorg-minimal.)
Comment 8 mew14930xvi 2024-10-04 13:18:07 UTC 
Created attachment 253991 [details]
fix xshogi not working

Remove post-patch:
Comment 9 commit-hook freebsd_committer freebsd_triage 2024-10-28 04:38:57 UTC 
A commit in branch main references this bug:

URL: https://cgit.FreeBSD.org/ports/commit/?id=8862ed973d74b83da10a5618c3fb290f1fc6216e

commit 8862ed973d74b83da10a5618c3fb290f1fc6216e
Author:     mew14930xvi <mew14930xvi@inbox.lv>
AuthorDate: 2024-10-28 04:29:57 +0000
Commit:     Zsolt Udvari <uzsolt@FreeBSD.org>
CommitDate: 2024-10-28 04:38:14 +0000

    games/gnushogi: Update WWW

    Remove INFO option.
    Use PLIST_FILES.
    Fix to DISTVERSION.
    Submitter takes maintainership.

    PR:             279993

 games/gnushogi/Makefile                            | 46 +++++++++-------------
 .../files/patch-gnushogi_commondsp.c (new)         | 10 +++++
 games/gnushogi/files/patch-gnushogi_cursesdsp.c    | 12 +++++-
 games/gnushogi/files/patch-gnushogi_globals.c      |  2 +-
 games/gnushogi/files/patch-gnushogi_init.c         |  9 -----
 games/gnushogi/files/patch-gnushogi_rawdsp.c       | 12 +++++-
 games/gnushogi/pkg-descr                           |  2 +-
 games/gnushogi/pkg-plist (gone)                    |  8 ----
 8 files changed, 51 insertions(+), 50 deletions(-)
Comment 10 Zsolt Udvari freebsd_committer freebsd_triage 2024-10-28 04:39:18 UTC 
Committed, thanks!